Closed
Bug 1240896
Opened 9 years ago
Closed 9 years ago
Switch to iframe mozbrowser
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox46 affected, firefox48 fixed)
People
(Reporter: jryans, Assigned: jryans)
References
(Depends on 1 open bug)
Details
(Whiteboard: [multiviewport] [mvp-rdm])
Attachments
(6 files)
(deleted),
text/x-review-board-request
|
gl
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
gl
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
gl
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
gl
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
gl
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
gl
:
review+
|
Details |
The initial shell in bug 1239437 uses a regular <iframe> to display the web content. This is not what we want to actually ship.
Instead, we need to change to <iframe mozbrowser>, which gives a truly separate browser runtime (similar to <xul:browser>), allows running in a child process, etc.
Bug 1238160 tracks enabling this feature on desktop. Once it is, we can enable it in RDM here.
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify-
Updated•9 years ago
|
Priority: -- → P2
Updated•9 years ago
|
Priority: P2 → P1
Whiteboard: [multiviewport] → [multiviewport] [mvp-rdm]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jryans
Updated•9 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 48.1 - Mar 21
Updated•9 years ago
|
Iteration: 48.1 - Mar 21 → 48.2 - Apr 4
Assignee | ||
Comment 1•9 years ago
|
||
I'm removing swapFrameLoaders (bug 1242644) from the scope of this bug, as it's making things too complex to switch to mozbrowser *and* use swapFrameLoaders in the same task.
Bug 1240913 is likely where we'll make use of swapFrameLoaders.
No longer depends on: 1242644
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43973/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43973/
Attachment #8737437 -
Flags: review?(gl)
Attachment #8737438 -
Flags: review?(gl)
Attachment #8737439 -
Flags: review?(gl)
Attachment #8737440 -
Flags: review?(gl)
Attachment #8737441 -
Flags: review?(gl)
Attachment #8737442 -
Flags: review?(gl)
Assignee | ||
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43975/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43975/
Assignee | ||
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43977/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43977/
Assignee | ||
Comment 5•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43979/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43979/
Assignee | ||
Comment 6•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43981/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43981/
Assignee | ||
Comment 7•9 years ago
|
||
This also adds the test infrastructure for detecting content resizing.
Review commit: https://reviewboard.mozilla.org/r/43983/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43983/
Assignee | ||
Comment 8•9 years ago
|
||
Comment 9•9 years ago
|
||
Comment on attachment 8737437 [details]
MozReview Request: Bug 1240896 - Use iframe mozbrowser in RDM. r=gl
https://reviewboard.mozilla.org/r/43973/#review40693
Attachment #8737437 -
Flags: review?(gl) → review+
Comment 10•9 years ago
|
||
Comment on attachment 8737438 [details]
MozReview Request: Bug 1240896 - Uplift dimensions to avoid recreating iframe. r=gl
https://reviewboard.mozilla.org/r/43975/#review40711
Attachment #8737438 -
Flags: review?(gl) → review+
Comment 11•9 years ago
|
||
Comment on attachment 8737439 [details]
MozReview Request: Bug 1240896 - Reorder imports to match style. r=gl
https://reviewboard.mozilla.org/r/43977/#review40713
Attachment #8737439 -
Flags: review?(gl) → review+
Comment 12•9 years ago
|
||
Comment on attachment 8737440 [details]
MozReview Request: Bug 1240896 - Port browser_resize_cmd.js, add resize to support. r=gl
https://reviewboard.mozilla.org/r/43979/#review40729
I think the commit msg should be: Port browser_responsive_cmd.js, add gcli resize support
Attachment #8737440 -
Flags: review?(gl) → review+
Updated•9 years ago
|
Attachment #8737441 -
Flags: review?(gl) → review+
Comment 13•9 years ago
|
||
Comment on attachment 8737441 [details]
MozReview Request: Bug 1240896 - Load frame script into RDM browser. r=gl
https://reviewboard.mozilla.org/r/43981/#review40757
Comment 14•9 years ago
|
||
Comment on attachment 8737442 [details]
MozReview Request: Bug 1240896 - Port browser_device_width.js to new RDM. r=gl
https://reviewboard.mozilla.org/r/43983/#review40803
Attachment #8737442 -
Flags: review?(gl) → review+
Comment 15•9 years ago
|
||
I noticed that we will get an error for google.com with these patches applied.
STR:
1. Navigate to http://google.com/
2. Open RDM
3. Observe console error
DOMException [SyntaxError: "An invalid or illegal string was specified"
code: 12
nsresult: 0x8053000c
index.js:125:5
Assignee | ||
Comment 16•9 years ago
|
||
(In reply to Gabriel Luong [:gl] (ΦωΦ) from comment #12)
> Comment on attachment 8737440 [details]
> MozReview Request: Bug 1240896 - Port browser_resize_cmd.js, add resize to
> support. r=gl
>
> https://reviewboard.mozilla.org/r/43979/#review40729
>
> I think the commit msg should be: Port browser_responsive_cmd.js, add gcli
> resize support
Okay, renamed.
Assignee | ||
Comment 17•9 years ago
|
||
(In reply to Gabriel Luong [:gl] (ΦωΦ) from comment #15)
> I noticed that we will get an error for google.com with these patches
> applied.
>
> STR:
> 1. Navigate to http://google.com/
> 2. Open RDM
> 3. Observe console error
> DOMException [SyntaxError: "An invalid or illegal string was specified"
> code: 12
> nsresult: 0x8053000c
> index.js:125:5
Ah, good catch, I needed to escape any instances of & in the URL.
Updated•9 years ago
|
Iteration: 48.2 - Apr 4 → 48.3 - Apr 18
Comment 18•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0070ee7b52a3
https://hg.mozilla.org/integration/fx-team/rev/d9b17ba5ebc2
https://hg.mozilla.org/integration/fx-team/rev/a6c421e444d0
https://hg.mozilla.org/integration/fx-team/rev/311e7a5e811b
https://hg.mozilla.org/integration/fx-team/rev/9bf82cf8e9a2
https://hg.mozilla.org/integration/fx-team/rev/6d6b9a38bc48
https://hg.mozilla.org/integration/fx-team/rev/01267cc7cc8f
https://hg.mozilla.org/integration/fx-team/rev/c725fad03087
https://hg.mozilla.org/integration/fx-team/rev/8fc46323cee6
Comment 19•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0070ee7b52a3
https://hg.mozilla.org/mozilla-central/rev/d9b17ba5ebc2
https://hg.mozilla.org/mozilla-central/rev/a6c421e444d0
https://hg.mozilla.org/mozilla-central/rev/311e7a5e811b
https://hg.mozilla.org/mozilla-central/rev/9bf82cf8e9a2
https://hg.mozilla.org/mozilla-central/rev/6d6b9a38bc48
https://hg.mozilla.org/mozilla-central/rev/01267cc7cc8f
https://hg.mozilla.org/mozilla-central/rev/c725fad03087
https://hg.mozilla.org/mozilla-central/rev/8fc46323cee6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•