Hi Edgar, Could you review the patch to enable wifi tethering test cases on all versions and EAP related test cases on post-KK emulator? Thanks!

Comment on attachment 8712026 [details] [diff] [review] 0001-Bug-1241000-Enable-all-wifi-emulator-test-case.-r-ed.patch Review of attachment 8712026 [details] [diff] [review]: ----------------------------------------------------------------- Thank you.

I will help to do check-in.

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a86f52235bc&exclusion_profile=false&group_state=expanded&filter-searchStr=emulator%20x86

Since there are some tethering tests that are not enabled yet [1], I mark this bug as leave-open. Thanks. [1] https://dxr.mozilla.org/mozilla-central/source/testing/marionette/client/marionette/tests/webapi-tests.ini#29

I triggered try run with enabling tests under dom/tethering/ [1] and I got below error, TEST-UNEXPECTED-FAIL | test_wifi_tethering_enabled.js | Promise rejects during test(MASQUERADE not found while tethering is enabled) - false was false, expected true TEST-UNEXPECTED-FAIL | test_wifi_tethering_enabled.js | AssertionError: 1 tests failed TEST-UNEXPECTED-FAIL | test_wifi_tethering_dun.js | Promise rejects during test(MASQUERADE not found while tethering is enabled) - false was false, expected true TEST-UNEXPECTED-FAIL | test_wifi_tethering_dun.js | AssertionError: 1 tests failed [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccb996719b38&exclusion_profile=false&group_state=expanded

Removing leave-open keyword from resolved bugs, per :sylvestre.