Closed Bug 1241339 Opened 9 years ago Closed 9 years ago

ObserverService may keep Console object alive until shutdown

Categories

(Core :: DOM: Core & HTML, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

Details

(Whiteboard: [MemShrink])

Attachments

(2 files)

Attached file test (deleted) —
patch coming
Blocks: 1241271
Whiteboard: [MemShrink]
that expando in the test shouldn't even be needed.
Attached patch v1 (deleted) — Splinter Review
This is the safest possible, even for branches, I could think of. We may want to tweak that notification firing for this kind of edge cases too. https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf5cab10df61 I'm not sure if this helps with bug 1241271
Attachment #8710219 - Flags: review?(amarchesini)
Opt builds https://treeherder.mozilla.org/#/jobs?repo=try&revision=5afd0fa1bd95 smaug does tryserver have links to the place where one can download the builds? smaug s/tryserver/treeherder/ perhaps RyanVM|afk smaug: yes RyanVM|afk smaug: click on the B in question RyanVM|afk bottom left pane RyanVM|afk Build: <some linkified name> RyanVM|afk i.e. Build: x86_64 linux64 linux RyanVM|afk that'll take you to the build dir
Attachment #8710219 - Flags: review?(amarchesini) → review+
Jukka, want to test those tryserver builds whether it helps with the leak?
Flags: needinfo?(jujjyl)
Thanks Olli, I'll update to use this build as soon as it lands to Nightly. Looks like the bug does not manifest 100% reproducibly, so I am unable to say for certainty if this fixes the issue, but I'll keep an eye out if this occurs and do CC log captures when it does.
Flags: needinfo?(jujjyl)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: