Closed
Bug 1241339
Opened 9 years ago
Closed 9 years ago
ObserverService may keep Console object alive until shutdown
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
(Whiteboard: [MemShrink])
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
patch coming
Updated•9 years ago
|
Whiteboard: [MemShrink]
Assignee | ||
Comment 1•9 years ago
|
||
that expando in the test shouldn't even be needed.
Assignee | ||
Comment 2•9 years ago
|
||
This is the safest possible, even for branches, I could think of.
We may want to tweak that notification firing for this kind of edge cases too.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf5cab10df61
I'm not sure if this helps with bug 1241271
Attachment #8710219 -
Flags: review?(amarchesini)
Assignee | ||
Comment 3•9 years ago
|
||
Opt builds https://treeherder.mozilla.org/#/jobs?repo=try&revision=5afd0fa1bd95
smaug does tryserver have links to the place where one can download the builds?
smaug s/tryserver/treeherder/ perhaps
RyanVM|afk smaug: yes
RyanVM|afk smaug: click on the B in question
RyanVM|afk bottom left pane
RyanVM|afk Build: <some linkified name>
RyanVM|afk i.e. Build: x86_64 linux64 linux
RyanVM|afk that'll take you to the build dir
Updated•9 years ago
|
Attachment #8710219 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Jukka, want to test those tryserver builds whether it helps with the leak?
Flags: needinfo?(jujjyl)
Comment 6•9 years ago
|
||
Thanks Olli, I'll update to use this build as soon as it lands to Nightly. Looks like the bug does not manifest 100% reproducibly, so I am unable to say for certainty if this fixes the issue, but I'll keep an eye out if this occurs and do CC log captures when it does.
Flags: needinfo?(jujjyl)
Comment 7•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•