Closed Bug 1241570 Opened 9 years ago Closed 9 years ago

[e10s] Intermittent browser_perf-highlighted.js, browser_perf-telemetry.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(e10s+, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
e10s + ---
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: aryx, Assigned: vporof)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

08:53:25 INFO - 271 INFO TEST-START | devtools/client/performance/test/browser_perf-highlighted.js 08:54:13 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost 08:54:13 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost 08:54:13 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost 08:54:13 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost 08:54:13 INFO - ###!!! [Parent][OnMaybeDequeueOne] Error: Channel closing: too late to send/recv, messages will be lost 08:54:13 INFO - TEST-INFO | started process screentopng 08:54:16 INFO - TEST-INFO | screentopng: exit 0 08:54:16 INFO - 272 INFO checking window state 08:54:16 INFO - 273 INFO Initializing a performance pane. 08:54:16 INFO - 274 INFO Adding tab: http://example.com/browser/devtools/client/performance/test/doc_simple-test.html 08:54:16 INFO - 275 INFO Tab added and finished loading: http://example.com/browser/devtools/client/performance/test/doc_simple-test.html 08:54:16 INFO - 276 INFO Waiting for event: 'recording-started' on [Front for performance/server1.conn27.child1/performanceActor22] 08:54:16 INFO - 277 INFO Received event: 'recording-started' on [Front for performance/server1.conn27.child1/performanceActor22] 08:54:16 INFO - 278 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | performance tab is highlighted during recording from console.profile when unloaded - 08:54:16 INFO - 279 INFO Waiting for event: 'recording-stopped' on [Front for performance/server1.conn27.child1/performanceActor22] 08:54:16 INFO - 280 INFO Received event: 'recording-stopped' on [Front for performance/server1.conn27.child1/performanceActor22] 08:54:16 INFO - 281 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | performance tab is no longer highlighted when console.profile recording finishes - 08:54:16 INFO - 282 INFO Waiting for event: 'Performance:UI:StateChanged' on [object PerformanceView] 08:54:16 INFO - 283 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should not be checked yet. - 08:54:16 INFO - 284 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should not be locked yet. - 08:54:16 INFO - 285 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should now be checked. - 08:54:16 INFO - 286 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should be locked. - 08:54:16 INFO - 287 INFO Received event: 'recording-started' on [Front for performance/server1.conn27.child1/performanceActor22] 08:54:16 INFO - 288 INFO Received event: 'Performance:UI:StateChanged' on [object PerformanceView] 08:54:16 INFO - 289 INFO Waiting for event: 'Performance:UI:OverviewRendered' on [object OverviewView] 08:54:16 INFO - 290 INFO Received event: 'Performance:UI:OverviewRendered' on [object OverviewView] 08:54:16 INFO - 291 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The current state is 'recording'. - 08:54:16 INFO - 292 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should still be checked. - 08:54:16 INFO - 293 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should not be locked. - 08:54:16 INFO - 294 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | performance tab is highlighted during recording while in performance tool - 08:54:16 INFO - 295 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should already be checked. - 08:54:16 INFO - 296 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should not be locked yet. - 08:54:16 INFO - 297 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should not be checked. - 08:54:16 INFO - 298 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should be locked. - 08:54:16 INFO - 299 INFO Waiting for event: 'Performance:UI:StateChanged' on [object PerformanceView] 08:54:16 INFO - 300 INFO Received event: 'recording-stopped' on [Front for performance/server1.conn27.child1/performanceActor22] 08:54:16 INFO - 301 INFO Received event: 'Performance:UI:StateChanged' on [object PerformanceView] 08:54:16 INFO - 302 INFO Waiting for event: 'Performance:UI:OverviewRendered' on [object OverviewView] 08:54:16 INFO - 303 INFO Received event: 'Performance:UI:OverviewRendered' on [object OverviewView] 08:54:16 INFO - 304 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The current state is 'recorded'. - 08:54:16 INFO - 305 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should not be checked. - 08:54:16 INFO - 306 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | The record button should not be locked. - 08:54:16 INFO - 307 INFO TEST-PASS | devtools/client/performance/test/browser_perf-highlighted.js | performance tab is no longer highlighted when recording finishes - 08:54:16 INFO - 308 INFO Destroying the performance tool. 08:54:16 INFO - 309 INFO Removing tab. 08:54:16 INFO - 310 INFO Tab removed and finished closing. 08:54:16 INFO - 311 INFO finish() was called, cleaning up... 08:54:16 INFO - 312 INFO TEST-UNEXPECTED-FAIL | devtools/client/performance/test/browser_perf-highlighted.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 08:54:16 INFO - MEMORY STAT | vsize 7284MB | residentFast 254MB | heapAllocated 98MB 08:54:16 INFO - 313 INFO TEST-OK | devtools/client/performance/test/browser_perf-highlighted.js | took 48315ms
Summary: Intermittent e10s browser_perf-highlighted.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - → Intermittent e10s browser_perf-highlighted.js,browser_perf-telemetry.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -
Blocks: e10s-tests
tracking-e10s: --- → +
Brian, Ryan, this is the top intermittent today. Any thoughts on who could work this?
Flags: needinfo?(jryans)
Flags: needinfo?(bgrinstead)
I'll grab this, thanks Ben
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Flags: needinfo?(jryans)
Flags: needinfo?(bgrinstead)
I have a patch that seems to make this permafail: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f57461282b2 Or maybe I just got really unlucky in my retriggers. Should I block on a fix here? Or should I temporarily add 'requestLongerTimeout' to get my patch landed?
Nvm, KWierso pointed out that this recently got much worse and is just as orange on inbound. I must have gotten unlucky and pushed my try change just before the thing that made it more intermittent.
No longer blocks: 1231784
(In reply to Andrew Halberstadt [:ahal] from comment #8) > Nvm, KWierso pointed out that this recently got much worse and is just as > orange on inbound. I must have gotten unlucky and pushed my try change just > before the thing that made it more intermittent. is there a way to fix this, seems this got perma orange ?
Flags: needinfo?(ahalberstadt)
My patch got backed out, I guess it does turn this permafail after all. I could add a requestLongerTimeout to the manifest for this test until Jordan has a chance to fix this properly. Unless the fix is imminent, then I wouldn't bother. Jordan, do you have any estimate on this?
Flags: needinfo?(ahalberstadt) → needinfo?(jsantell)
Triaging. Filter on LULUGUBRIOUSUS.
Blocks: perf-orange
Summary: Intermittent e10s browser_perf-highlighted.js,browser_perf-telemetry.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - → [e10s] Intermittent browser_perf-highlighted.js, browser_perf-telemetry.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
ahal's patch wasn't backed out for turning this permaorange, and it remains permaorange without his patch landed: 25 of 25 runs on linux32 e10s, 22 of 25 runs on linux64 e10s.
Taking a stab at this.
Attached patch v1 (deleted) — Splinter Review
Assignee: jsantell → vporof
Attachment #8715918 - Flags: review?(jsantell)
Looks like another instance of a test not starting for a minute, probably because of a proceeding test?
Flags: needinfo?(jsantell)
Comment on attachment 8715918 [details] [diff] [review] v1 Review of attachment 8715918 [details] [diff] [review]: ----------------------------------------------------------------- Shame that this will probably result in longer test times overall, but hopefully fixes the issue..
Attachment #8715918 - Flags: review?(jsantell) → review+
Landing.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
No longer blocks: perf-orange
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: