Closed
Bug 124164
Opened 23 years ago
Closed 23 years ago
Input Field Height Less Than Text Height When SIZE =x,1
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: mrmazda, Assigned: jhpedemonte)
References
()
Details
Attachments
(4 files, 1 obsolete file)
(deleted),
image/jpeg
|
Details | |
(deleted),
text/html
|
Details | |
(deleted),
patch
|
mkaply
:
review+
mkaply
:
superreview+
shaver
:
approval+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mkaply
:
review+
mkaply
:
superreview+
scc
:
approval+
|
Details | Diff | Splinter Review |
2002020417
Using proportional sans-serif, 12 px Helv, and allow other fonts unselected in
prefs, entry box is insufficient height to show full character height. Lower
case "g" and "q" are indistinguishable.
Comment 1•23 years ago
|
||
This is the forms.css problem I have mentioned on the newsgroups.
Because forms.css is specifying operating system fonts for controls on web
pages, and because the OS font that OS/2 uses is WarpSans 9 pt which cannot be
made smaller, this happens.
The solution is to fix forms.css which I have done in the 0.9.8 ship.
The other solution is for me to stop using WarpSans and switch to using Helv or
such for the UI font, but I don't think that is correct.
*** This bug has been marked as a duplicate of 53617 ***
Status: UNCONFIRMED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 2•23 years ago
|
||
Bug 53617 looks like a font selection problem to me. This bug is not about the
font selection, which is perfect. The font is simply not given sufficient room
to display.
Comment 4•23 years ago
|
||
Comment 5•23 years ago
|
||
Reassigning
Assignee: alexsavulov → pedemont
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 6•23 years ago
|
||
please also change component. this is not form submission
thx!
Updated•23 years ago
|
Component: Form Submission → HTML Form Controls
Assignee | ||
Comment 7•23 years ago
|
||
This patch should fix the issue where some letters ('g', 'y', 'j',...) were
getting cut off in text fields.
Assignee | ||
Comment 8•23 years ago
|
||
Forgot some files.
Attachment #79821 -
Attachment is obsolete: true
Updated•23 years ago
|
QA Contact: vladimire → tpreston
Comment 9•23 years ago
|
||
Comment on attachment 79822 [details] [diff] [review]
fontmetrics change
r=mkaply
sr=blizzard (platform specific code)
Attachment #79822 -
Flags: superreview+
Attachment #79822 -
Flags: review+
Comment 10•23 years ago
|
||
Comment on attachment 79822 [details] [diff] [review]
fontmetrics change
sr=attinasi for changes to nsIFontMetrics.h
Comment on attachment 79822 [details] [diff] [review]
fontmetrics change
a=shaver for the 1.0 branch.
Attachment #79822 -
Flags: approval+
Comment 12•23 years ago
|
||
I should never have put this code in rulenode.
The correct fix is in 67749 - platform specific forms.css
Comment 13•23 years ago
|
||
Comment on attachment 80733 [details] [diff] [review]
Remove code from rulenode
I've discussed this with Javier as the right fix, so I am taking the r= from
him.
Sinc eI am only removing an XP_OS2 chunk, sr=blizzard.
Attachment #80733 -
Flags: superreview+
Attachment #80733 -
Flags: review+
Comment 14•23 years ago
|
||
Comment on attachment 80733 [details] [diff] [review]
Remove code from rulenode
a=scc for checkin to the mozilla 1.0 branch
Attachment #80733 -
Flags: approval+
Comment 15•23 years ago
|
||
I'm marking this bug fixed, although it won't be totally fixed on the branch
until I get the forms.css fix from 67749 in.
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Comment 17•23 years ago
|
||
adding branch verification keyword. This bug has been verified in a comment,
just moving that to the keyword field.
Keywords: verified1.0.0
You need to log in
before you can comment on or make changes to this bug.
Description
•