Closed Bug 124164 Opened 23 years ago Closed 23 years ago

Input Field Height Less Than Text Height When SIZE =x,1

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Platform:
x86
OS/2
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mrmazda, Assigned: jhpedemonte)

References

(
URL
)

Details

Attachments

(4 files, 1 obsolete file)

Text Taller Than Input Field
(deleted), image/jpeg
Details
testcase
(deleted), text/html
Details
fontmetrics change
(deleted), patch
mkaply
: review+
mkaply
: superreview+
shaver
: approval+
Details | Diff | Splinter Review
Remove code from rulenode
(deleted), patch
mkaply
: review+
mkaply
: superreview+
scc
: approval+
Details | Diff | Splinter Review
2002020417 Using proportional sans-serif, 12 px Helv, and allow other fonts unselected in prefs, entry box is insufficient height to show full character height. Lower case "g" and "q" are indistinguishable.
This is the forms.css problem I have mentioned on the newsgroups. Because forms.css is specifying operating system fonts for controls on web pages, and because the OS font that OS/2 uses is WarpSans 9 pt which cannot be made smaller, this happens. The solution is to fix forms.css which I have done in the 0.9.8 ship. The other solution is for me to stop using WarpSans and switch to using Helv or such for the UI font, but I don't think that is correct. *** This bug has been marked as a duplicate of 53617 ***
Status: UNCONFIRMED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
Attached image Text Taller Than Input Field (deleted) —
Bug 53617 looks like a font selection problem to me. This bug is not about the font selection, which is perfect. The font is simply not given sufficient room to display.
My bad
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Attached file testcase (deleted) —
Reassigning
Assignee: alexsavulov → pedemont
Status: UNCONFIRMED → NEW
Ever confirmed: true
please also change component. this is not form submission thx!
Component: Form Submission → HTML Form Controls
Attached patch fontmetrics change (obsolete) (deleted) — — Splinter Review
This patch should fix the issue where some letters ('g', 'y', 'j',...) were getting cut off in text fields.
Attached patch fontmetrics change (deleted) — — Splinter Review
Forgot some files.
Attachment #79821 - Attachment is obsolete: true
QA Contact: vladimire → tpreston
Comment on attachment 79822 [details] [diff] [review] fontmetrics change r=mkaply sr=blizzard (platform specific code)
Attachment #79822 - Flags: superreview+
Attachment #79822 - Flags: review+
Comment on attachment 79822 [details] [diff] [review] fontmetrics change sr=attinasi for changes to nsIFontMetrics.h
Comment on attachment 79822 [details] [diff] [review] fontmetrics change a=shaver for the 1.0 branch.
Attachment #79822 - Flags: approval+
Attached patch Remove code from rulenode (deleted) — — Splinter Review
I should never have put this code in rulenode. The correct fix is in 67749 - platform specific forms.css
Comment on attachment 80733 [details] [diff] [review] Remove code from rulenode I've discussed this with Javier as the right fix, so I am taking the r= from him. Sinc eI am only removing an XP_OS2 chunk, sr=blizzard.
Attachment #80733 - Flags: superreview+
Attachment #80733 - Flags: review+
Comment on attachment 80733 [details] [diff] [review] Remove code from rulenode a=scc for checkin to the mozilla 1.0 branch
Attachment #80733 - Flags: approval+
I'm marking this bug fixed, although it won't be totally fixed on the branch until I get the forms.css fix from 67749 in.
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Verified fixed in 2002042409
Status: RESOLVED → VERIFIED
adding branch verification keyword. This bug has been verified in a comment, just moving that to the keyword field.
Keywords: verified1.0.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: