Closed Bug 1241723 Opened 9 years ago Closed 9 years ago

Update WebKitCSSMatrix.idl to match spec updates (optional args that default to 0)

Categories

(Core :: DOM: CSS Object Model, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: miketaylr, Assigned: miketaylr)

References

Details

Attachments

(1 file)

The spec was missing optional args that default to 0 for the following methods: skewX, skewY, rotateAxisAngle, translate The Spec IDL has been updated: https://compat.spec.whatwg.org/#webkitcssmatrix-interface
The following methods have been updated to match WebKit's behavior, taking optional arguments that default to 0: rotateAxisAngle() skewX() skewY() translate()
Attachment #8710795 - Flags: review?(wchen)
Attachment #8710795 - Flags: review?(wchen) → review?(amarchesini)
Blocks: 1242333
Assignee: nobody → miket
Attachment #8710795 - Flags: review?(amarchesini) → review+
Thanks for the review!
Try looks good (some unrelated timeouts), will land when inbound is green.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8710795 [details] [diff] [review] Update WebKitCSSMatrix.idl to match latest spec updates. Approval Request Comment [Feature/regressing bug #]: Feature is Bug 717722. The known regressions are Bug 1241786 and Bug 1242333. When I wrote the spec I wasn't aware that web content depended on calling certain methods with default args -- sites broke and now we know. [User impact if declined]: Aurora/Dev Edition users will have a few high-profile broken sites. :( (Google Photos and Google Plus, probably more we don't know about) [Describe test coverage new/current, TreeHerder]: Try run in comments. [Risks and why]: Low risks. This change just adds default argument values to 4 WebKitCSSMatrix methods in the webidl. [String/UUID change made/needed]: None (no UUIDs are involved in webidl, right?)
Attachment #8710795 - Flags: approval-mozilla-aurora?
Comment on attachment 8710795 [details] [diff] [review] Update WebKitCSSMatrix.idl to match latest spec updates. More web compat fixes, affects popular sites. Please uplift to aurora.
Attachment #8710795 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No longer blocks: 1241786
No longer blocks: 1242333
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: