Implement support for -moz-window-dragging in GTK and remove toolkit toolbar-drag binding
Categories
(Core :: Widget: Gtk, task, P5)
Tracking
()
People
(Reporter: Gijs, Assigned: ntim)
References
Details
(Whiteboard: tpi:+)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
|
||
Updated•8 years ago
|
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
||
Updated•6 years ago
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
|
Assignee | |
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
||
Comment 5•6 years ago
|
||
|
|
Assignee | |
Comment 6•6 years ago
|
||
|
||
Comment 7•6 years ago
|
||
IIUC the history here is that toolbar-drag and/or WindowDraggingUtils existed first. -moz-window-dragging was added for https://bugzilla.mozilla.org/show_bug.cgi?id=944836 so that MacOS could perform the dragging without involvement of the app. NT support was added for bug 1163113 for B2G, but not used in real products until https://bugzilla.mozilla.org/show_bug.cgi?id=1219215#c4 . The reasons are not all clear to me, but efficiency of hit testing for frequent NT messages is the reason indicated in https://bugzilla.mozilla.org/show_bug.cgi?id=1107779#c7
I don't know that GTK code can have the same benefits as MacOS and doing hit-testing in the widget code feels a bit awkward to me, but doing things the same way on all platforms seems a good reason to do this.
|
|
Assignee | |
Comment 8•6 years ago
|
||
(In reply to Karl Tomlinson (:karlt) from comment #7)
IIUC the history here is that toolbar-drag and/or WindowDraggingUtils existed first. -moz-window-dragging was added for https://bugzilla.mozilla.org/show_bug.cgi?id=944836 so that MacOS could perform the dragging without involvement of the app. NT support was added for bug 1163113 for B2G, but not used in real products until https://bugzilla.mozilla.org/show_bug.cgi?id=1219215#c4 . The reasons are not all clear to me, but efficiency of hit testing for frequent NT messages is the reason indicated in https://bugzilla.mozilla.org/show_bug.cgi?id=1107779#c7
I don't know that GTK code can have the same benefits as MacOS and doing hit-testing in the widget code feels a bit awkward to me, but doing things the same way on all platforms seems a good reason to do this.
In addition to being consistent across platforms, we want to get rid of XBL here too, which is the major benefit of doing this.
|
|
||
Updated•6 years ago
|
|
|
||
Updated•6 years ago
|
|
||
Comment 10•6 years ago
|
||
|
||
Comment 11•6 years ago
|
||
Backed out for build bustages
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=222758833&repo=autoland&lineNumber=44694
Backout: https://hg.mozilla.org/integration/autoland/rev/0771389994bb84e406bb1f335903c7c5c98d78e5
|
|
Assignee | |
Updated•6 years ago
|
|
|
||
Comment 12•6 years ago
|
||
|
||
Comment 13•6 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•3 years ago
|
Description
•