Closed Bug 1241902 Opened 9 years ago Closed 4 years ago

[Lint: CommitTransaction] Fix Missing Fragment transaction commit call

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: vivek, Unassigned)

References

Details

In TabHistoryFragment commit is called in show step [1]. However, Lint complains at the caller [2] about missing commit call. To fix this either refactor the show() function to create a new fragment transaction instead of passing it along or add SuppressLint annotation for CommitTransaction. [1] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/tabs/TabHistoryFragment.java?case=true&from=TabHistoryFragment.java#125 [2] https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java?from=BrowserAPp.java#615
Summary: [Lint] Fix Missing Fragment transaction commit call → [Lint: CommitTransaction] Fix Missing Fragment transaction commit call
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.