Hi mstange, could you please let me know if the fix for this test is the right one? How can I know if asyncPan is enabled for the reftest run? I think it is from looking at [0] Linux x64 debug reftest e10s 3 inside of docker is failing with something weird happening at the edge of the scoll bars [1][2] The exact steps to reproduce are listed in here. [3] The particular test is [4] Changing the fuzzing makes the test pass [5] dholbert recommends me to highlight this for more context: > max difference: 2, number of differing pixels: 52 [0] 19:26:28 INFO - REFTEST INFO | {"isDebugBuild":true,"xulRuntime":{"widgetToolkit":"gtk3","OS":"Linux","XPCOMABI":"x86_64-gcc3"},"smallScreen":false,"d2d":false,"azureCairo":true,"azureQuartz":false,"azureSkia":false,"skiaContent":false,"azureSkiaGL":0,"contentSameGfxBackendAsCanvas":true,"layersGPUAccelerated":false,"d3d11":false,"layersOpenGL":false,"layersOMTC":true,"B2G":false,"Android":false,"cocoaWidget":false,"gtkWidget":true,"qtWidget":false,"winWidget":false,"transparentScrollbars":true,"AddressSanitizer":false,"webrtc":true,"http":{"userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:46.0) Gecko/20100101 Firefox/46.0","appName":"Mozilla","appVersion":"5.0","platform":"X11","oscpu":"Linux x86_64","misc":"rv:46.0"},"haveTestPlugin":true,"windowsDefaultTheme":false,"nativeThemePref":true,"prefs":{},"browserIsRemote":true,"Mulet":false,"asyncPan":true,"asyncZoom":false} [1] http://people.mozilla.org/~armenzg/sattap/b26b91e8.png [2] http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/OMMx3mylSZW-hdBf1BGZdw/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1 [3] https://gist.github.com/armenzg/5d8da240d9c0915581df [4] https://dxr.mozilla.org/mozilla-central/source/layout/reftests/image-element/element-paint-native-widget.html?case=true&from=element-paint-native-widget.html [5] diff --git a/layout/reftests/image-element/reftest.list b/layout/reftests/image-element/reftest.list --- a/layout/reftests/image-element/reftest.list +++ b/layout/reftests/image-element/reftest.list @@ -20,1 +20,1 @@ fuzzy-if(d2d,255,24) == element-paint-tr -fuzzy-if(asyncPan,1,140) == element-paint-native-widget.html element-paint-native-widget-ref.html # in -ref the scrollframe is active +fuzzy-if(asyncPan,2,140) == element-paint-native-widget.html element-paint-native-widget-ref.html # in -ref the scrollframe is active

Bug 1195436 is when the 1 pixel fuzzing was added.

Hi Armen, yes, that is the right fix. Bug 1195436 comment 0 explains why we need fuzz here at all, and in those situations anything up to a difference of two is totally fine. Whether the needed max difference is 1 or 2 can depend on many things, and here with the scrollbars it also depends on what the system theme paints. I assume we're using a different linux theme in the docker images than in the previous environment. (In reply to Armen Zambrano [:armenzg] - Engineering productivity from comment #0) > How can I know if asyncPan is enabled for the reftest run? I think it is > from looking at [0] Correct.

Review commit: https://reviewboard.mozilla.org/r/32553/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/32553/

Comment on attachment 8712472 [details] MozReview Request: Bug 1242033 - Increase element-paint-native-widget.html element-paint-native-widget-ref.html max differences to 2. r=mstange https://reviewboard.mozilla.org/r/32553/#review29313

https://hg.mozilla.org/integration/mozilla-inbound/rev/22da82accc398fb9b29e2387eac52aab04d6bae2 Bug 1242033 - Increase element-paint-native-widget.html element-paint-native-widget-ref.html max differences to 2. r=mstange