Closed Bug 1242718 Opened 9 years ago Closed 8 years ago

Enable selection events outside of nightly

Categories

(Core :: DOM: Events, defect)

Product:
Core
Component:
DOM: Events
Version:
43 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1231923
Tracking Flags:
Tracking Status
firefox44 --- wontfix
firefox45 --- wontfix
firefox46 --- wontfix
firefox47 --- wontfix
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- affected
firefox51 --- affected

People

(Reporter: cyril.auburtin, Assigned: nika)

References

Details

(Keywords: testcase)

Attachments

(1 file)

Enable selection events outside of nightly
(deleted), patch
smaug
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.13 Safari/537.36 Steps to reproduce: demo: http://jsfiddle.net/3wLt19ca/2/ Actual results: wen selecting text, nothing happen in console, no selectionchange events Expected results: it should logs those events
Component: Untriaged → DOM: Events
Product: Firefox → Core
works on nightly
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9771bd5e56edd07e21cf008dcadc20d7ed970ce3&tochange=9ed17db42e3e46f1c712e4dffd62d54e915e0fac Bug 1196479 - Fire selectstart and selectionchange events on the input node when the selection in that editor changes. r=ehsan See also bug 1248148, it has an opposite expectations.
Blocks: 1196479
status-firefox44: --- → affected
status-firefox45: --- → affected
status-firefox46: --- → affected
status-firefox47: --- → ?
Keywords: testcase
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1248148
Version: 47 Branch → 45 Branch
status-firefox44: affected → wontfix
Version: 45 Branch → 43 Branch
document.addEventListener('selectionchange', e=>console.log('sel change')) is still not working in stable 47 and beta 48
Have we not enabled the events yet?
Flags: needinfo?(michael)
(In reply to Olli Pettay [:smaug] (high review load, please consider other reviewers) from comment #4) > Have we not enabled the events yet? I don't believe we have enabled them yet. To do that we just need to set the dom.select_events.enabled pref.
Flags: needinfo?(michael)
Thanks for enabling it, could you tell me for which version it'll land for sure? I've a polyfill http://jsfiddle.net/crl/rk6f74tw/32/ but I'd like to use only when necessary
50 maybe?
Assignee: nobody → michael
Summary: selectionchange event is not triggered → Enable selection events outside of nightly
This patch enables selection events outside of nightly
Comment on attachment 8764388 [details] [diff] [review] Enable selection events outside of nightly Review of attachment 8764388 [details] [diff] [review]: ----------------------------------------------------------------- Smaug, do you think we're ready to enable these outside of nightly?
Attachment #8764388 - Flags: review?(bugs)
Comment on attachment 8764388 [details] [diff] [review] Enable selection events outside of nightly I guess so. At least we'd get more feedback and if there are regressions on aurora/beta, we can disable easily.
Attachment #8764388 - Flags: review?(bugs) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/08845358703f Enable selection events outside of nightly, r=smaug
https://hg.mozilla.org/mozilla-central/rev/08845358703f
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Depends on: 1280534
Depends on: 1298970
Re-opening because of backout coming in bug 1280534 - Should be re-landable once bug 1298970 is fixed.
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: