Taguchi Fumihiko Reporter
	Description • 9 years ago

Although Fennec is connecting with fling-player app in firefox OS, it can't terminate app by press the x-mark in Fennec's control panel.
I expect that the seamless experience is launched and terminated fling-player from user's smart-phone.

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 1 • 9 years ago

This is by design and our UX can provide more detailed reason.

	Tori Chen [:tori]
	Comment 2 • 9 years ago

I think it should same as current behavior on Fennec. If the videos sent to chromecast will be terminated by pressing the x-mark, we should kill the video on TV side too.

SC, could you check Fennec's code and make sure we have same behavior as theirs? Thanks!

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 4 • 9 years ago

Comment on attachment 8713123 [details]
[gaia] schien:bug1242883-support-terminate-player > mozilla-b2g:master

Per discussion with Tori, UX wants fling player be terminated while user explicitly close session (via 'X' button on Fennec) but keep fling player if Fennec is force closed. Therefore I create a new command 'close' to support this use case.

	KM Lee [:rexboy] (inactivate after Sep. 22)
	Comment 5 • 9 years ago

Comment on attachment 8713123 [details]
[gaia] schien:bug1242883-support-terminate-player > mozilla-b2g:master

Looks good to me but we may need unit tests for this, whether in this bug or follow-up bugs.

add r? to fischer since most of the works are done by him.

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 6 • 9 years ago

update test case tv_apps/fling-player/test/unit/casting_message_test.js in latest pull request.

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 7 • 9 years ago

[Blocking Requested - why for this release]:

	Fischer [:Fischer]
	Comment 8 • 9 years ago

Comment on attachment 8713123 [details]
[gaia] schien:bug1242883-support-terminate-player > mozilla-b2g:master

Looks good to me, thanks.

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 9 • 9 years ago

Comment on attachment 8713123 [details]
[gaia] schien:bug1242883-support-terminate-player > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):1205977
[User impact] if declined:cannot manually close fling player from fennec
[Testing completed]: manual test
[Risk to taking this patch] (and alternatives if risky): no
[String changes made]: no

	Josh Cheng [:josh]
	Comment 10 • 9 years ago

Comment on attachment 8713123 [details]
[gaia] schien:bug1242883-support-terminate-player > mozilla-b2g:master

Approve for TV 2.5

	Carsten Book [:Tomcat]
	Comment 11 • 9 years ago

(In reply to Josh Cheng [:josh] from comment #10)
> Comment on attachment 8713123 [details]
> [gaia] schien:bug1242883-support-terminate-player > mozilla-b2g:master
> 
> Approve for TV 2.5

i got fatal: bad object efc30860b02e7345dd1c85e810cc7be90fa8bfaf

so i guess this needs to be merged first or ? before this can be on 2.5 ?

	Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) Assignee
	Comment 12 • 9 years ago

(In reply to Carsten Book [:Tomcat] from comment #11)
> (In reply to Josh Cheng [:josh] from comment #10)
> > Comment on attachment 8713123 [details]
> > [gaia] schien:bug1242883-support-terminate-player > mozilla-b2g:master
> > 
> > Approve for TV 2.5
> 
> i got fatal: bad object efc30860b02e7345dd1c85e810cc7be90fa8bfaf
> 
> so i guess this needs to be merged first or ? before this can be on 2.5 ?
@tomcat, pull request need to be merge to master branch before uplift.
Thanks!

	Carsten Book [:Tomcat]
	Comment 13 • 9 years ago

landed this as https://github.com/mozilla-b2g/gaia/commit/faf4cc7683adda7e375a334a6a824949678d2189 on gaia master

	Carsten Book [:Tomcat]
	Comment 14 • 9 years ago

https://github.com/mozilla-b2g/gaia/commit/d8477e0e18492dfc5db026226404adc47d916671

	Rid Pan
	Comment 15 • 9 years ago

Verify this issue on v2.6.
Pressing the x-mark in Fennec's control panel can terminate app.

Build ID               20160303150404
Gaia Revision          f41e046a5c6032d9ce281fdb96256be7fc9b0c0f
Gaia Date              2016-03-03 09:09:37
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2b5237c178ea02133a777396c24dd2b713f2b8ee
Gecko Version          47.0a1
Device Name            hammerhead
Firmware(Release)      5.1.1
Firmware(Incremental)  eng.worker.20160204.113511
Firmware Date          Thu Feb  4 11:35:29 UTC 2016
Bootloader             HHZ11k

	Rid Pan
	Comment 16 • 9 years ago

This issue is also not observed on v2.5.

Build ID               20151029030207
Gaia Revision          71952d4b5417796380ddab274c5566a8eced2f8b
Gaia Date              2016-03-04 08:37:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1e700005a0ddf2b17803213e1f3f8d78a7a618b8
Gecko Version          44.0a1
Device Name            hammerhead
Firmware(Release)      5.1.1
Firmware(Incremental)  eng.worker.20160204.113511
Firmware Date          Thu Feb  4 11:35:29 UTC 2016
Bootloader             HHZ11k