Closed
Bug 1242892
Opened 9 years ago
Closed 9 years ago
[Fennec] Wrong branding for Aurora 46.0a2 on API11 builds
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
ARM
Android
Tracking
(firefox46 verified, fennec46+)
RESOLVED
FIXED
People
(Reporter: u421692, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rail
:
review+
jlund
:
checkin+
|
Details | Diff | Splinter Review |
Install Aurora 46.0a2 build http://ftp.mozilla.org/pub/mobile/nightly/latest-mozilla-aurora-android-api-11/fennec-46.0a2.multi.android-arm.apk
Aurora has the Nightly name and icon.
Checked from about:buildconfig, the changeset is correct.
This do not affect API9 and x86 builds.
Comment 1•9 years ago
|
||
Rail, Mihai, looks like something went wrong during the merge?
Flags: needinfo?(rail)
Flags: needinfo?(mtabara)
Updated•9 years ago
|
status-firefox46:
--- → affected
tracking-firefox46:
--- → blocking
Updated•9 years ago
|
Component: Releases → Build Config & IDE Support
Product: Release Engineering → Firefox for Android
QA Contact: rail
Comment 2•9 years ago
|
||
Related to bug 1219094 maybe? jlund, can you take a look at this, please?
Flags: needinfo?(rail)
Flags: needinfo?(mtabara)
Flags: needinfo?(jlund)
Comment 3•9 years ago
|
||
ah, we switched to using api-15 based mozconfigs in gecko (mozharness, taskcluster and merge/migration logic). there was a delay as I wanted this to spread around before putting it into buildbot production. But with the migration happening yesterday, the merge script changes assumed we are using api-15 now.
I'll put up a patch now to fix that. I'll pause aurora updates while we figure this out.
Flags: needinfo?(jlund)
Comment 4•9 years ago
|
||
> I'll put up a patch now to fix that. I'll pause aurora updates while we
> figure this out.
looks like it has already been locked
Comment 5•9 years ago
|
||
based on:
jlund@hastings-163:~/devel/mozilla/cleanRepos/mozilla-aurora
> diff -p mobile/android/config/mozconfigs/android-api-11/nightly mobile/android/config/mozconfigs/android-api-15/nightly
--- mobile/android/config/mozconfigs/android-api-11/nightly 2016-01-26 18:12:37.000000000 +0000
+++ mobile/android/config/mozconfigs/android-api-15/nightly 2016-01-26 18:12:37.000000000 +0000
@@ -1,12 +1,12 @@
. "$topsrcdir/mobile/android/config/mozconfigs/common"
-ac_add_options --enable-profiling
+
# Android
ac_add_options --with-android-min-sdk=15
ac_add_options --target=arm-linux-androideabi
-ac_add_options --with-branding=mobile/android/branding/nightly
+ac_add_options --with-branding=mobile/android/branding/aurora
# This will overwrite the default of stripping everything and keep the symbol table.
# This is useful for profiling with eideticker. See bug 788680
Attachment #8712267 -
Flags: review?(rail)
Updated•9 years ago
|
Attachment #8712267 -
Flags: review?(rail) → review+
Updated•9 years ago
|
tracking-fennec: --- → ?
Comment 6•9 years ago
|
||
Comment on attachment 8712267 [details] [diff] [review]
160126_bug_1242892_fennec_api-11_branding.patch
thanks
https://hg.mozilla.org/releases/mozilla-aurora/rev/c1ee4d79de15
Attachment #8712267 -
Flags: checkin+
Verfied as fixed on Aurora 46.0a1(2015-01-27) on Nexus 9(Android 6.0)
Comment 8•9 years ago
|
||
great. apologies for the bug.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 9•9 years ago
|
||
(In reply to Jordan Lund (:jlund) from comment #8)
> great. apologies for the bug.
Jordan, please don't apologies! Only people who are not doing anything are not making mistake. ;)
Updated•9 years ago
|
tracking-fennec: ? → 46+
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•