Closed
Bug 124298
Opened 23 years ago
Closed 23 years ago
Move button submit/reset code into nsHTMLInputElement
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: bryner, Assigned: bryner)
References
Details
Attachments
(1 file)
(deleted),
patch
|
john
:
review+
attinasi
:
superreview+
|
Details | Diff | Splinter Review |
As a prerequisite for implementing the HTML button control in XBL, the form
submit logic needs to be moved to nsHTMLInputElement::HandleDOMEvent().
Currently it resides in nsHTMLButtonControlFrame::MouseClicked().
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
Comment on attachment 68457 [details] [diff] [review]
patch
r=jkeiser if you just put a big fat comment in MouseClicked() saying this is
not called (and maybe where to look for the click handler)
Attachment #68457 -
Flags: review+
Comment 3•23 years ago
|
||
Comment on attachment 68457 [details] [diff] [review]
patch
And remove the code from image the same way.
Comment 4•23 years ago
|
||
Comment on attachment 68457 [details] [diff] [review]
patch
sr=attinasi
Do we want to remove the same calls from the ImageControlFrame and the
TextControlFrame, and if so, the implementation from the FormControlHelper? It
is confusing to have some elements submitting from the frames, and some from
the content element.
Attachment #68457 -
Flags: superreview+
Assignee | ||
Comment 5•23 years ago
|
||
I had planned to go back and do some of this sort of cleanup once XBL form
controls are turned on permanently, when the frame code is removed.
Assignee | ||
Comment 6•23 years ago
|
||
checked in. i will clean up this code after XBL form controls are turned on,
when the old form control frames are removed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Updated•23 years ago
|
QA Contact: madhur → tpreston
You need to log in
before you can comment on or make changes to this bug.
Description
•