User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 Build ID: 20160106234723 Steps to reproduce: On one computer (computer A) sign in to sync check "preferences" on the "what to sync" page. Set the download preference to "always ask me where to save file" On another computer (computer B) sign in to sync download a file it puts it in the download folder (does not ask me where to save it) open preferences set download preference to "always ask" On a third computer: sign in to sync download a file it puts it in the "Downloads" folder (it does not ask me where to save it) Actual results: Each time I set up a new computer I have to set my preferences. At least the "always ask where to save dowloaded files" preference does not seem to be synced across computers. Expected results: I expect that when I sign in to sync on a new computer with the "sync preferences" box checked that my preferences will be synced to the new computer.

Firefox uses a "whitelist" of preferences to Sync - the list can be seen at https://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#1243. It certainly could be argued that this particular pref be synced.

Added a sync pref (default: true) for browser.download.useDownloadDir. Considered adding one for browser.download.dir, but I found that yielded unexpected behavior when given an invalid file path (which may occur when users create a custom download dir on Computer A, and then sync that to new Computer B).

Comment on attachment 8765682 [details] [diff] [review] fix.bug1243034.patch Review of attachment 8765682 [details] [diff] [review]: ----------------------------------------------------------------- That looks great, thanks - please upload a new patch with a description something like "Bug 1243034 - Sync "browser.download.useDownloadDir" preference. r=markh" and request review from me.

Sorry I wasn't clear - the "commit message" in the patch should have the new description as that it what will be checked in - the bugzilla description doesn't matter.

Whoops, sorry about that. Fixed commit message.

Comment on attachment 8765733 [details] [diff] [review] fix.bug1243034.patch (Amended commit msg) Review of attachment 8765733 [details] [diff] [review]: ----------------------------------------------------------------- Awesome, thanks

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/a002011f787d Sync "browser.download.useDownloadDir" preference added. r=markh

Adding dev-doc-needed as it's a small new feature for Sync users.