Closed
Bug 1243037
Opened 9 years ago
Closed 9 years ago
enable rust for win64 nightly/aurora builds
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(4 files)
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1184732 +++
To get some testing we should enable rust for integration and nightly build for our 64-bit windows builds.
Assignee | ||
Comment 1•9 years ago
|
||
These patches are essentially the patches from bug 1184732, tweaked to only
support win64.
Repackaged upstream builds using bzip2. Builders don't seem to have xz.
Attachment #8712678 -
Flags: review?(mshal)
Assignee | ||
Comment 2•9 years ago
|
||
Because of how subshells and exporting variables works with msys bash,
we need to explicitly re-export everything interesting for things
executed downstream from configure.
Attachment #8712679 -
Flags: review?(mshal)
Assignee | ||
Comment 3•9 years ago
|
||
We can use the unix mozconfig.rust because it's generic.
Attachment #8712680 -
Flags: review?(mshal)
Assignee | ||
Comment 4•9 years ago
|
||
The unix mozconfig.rust is actually completely generic now that we're
using toolchains built with --enable-rpath in tooltool.
Move the mozconfig.rust fragment up a level to reduce confusion.
Attachment #8712681 -
Flags: review?(mshal)
Updated•9 years ago
|
Attachment #8712678 -
Flags: review?(mshal) → review+
Updated•9 years ago
|
Attachment #8712679 -
Flags: review?(mshal) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8712680 [details] [diff] [review]
part 3 - enable rust on win64 nightly builds.
I think it would be a little more straightforward if parts 3 & 4 were swapped. ie: Make a common mozconfig.rust file, then use it in win64 configs.
Attachment #8712680 -
Flags: review?(mshal) → review+
Comment 6•9 years ago
|
||
Comment on attachment 8712681 [details] [diff] [review]
part 4 - share mozconfig.rust between linux and windows
Can we also remove build/macosx/mozconfig.rust? It has the same RUSTC & ac_add_options lines, but with a strange check for `uname -s` != Linux (which doesn't make a ton of sense in an OSX specific file).
Attachment #8712681 -
Flags: review?(mshal) → review+
Comment 7•9 years ago
|
||
That uname check is just a crappy hack to keep it from breaking the Taskcluster cross-compile builds :-/
I assume between froydnj and rillian there's enough knowledge on how to package a Linux rustc that can cross-compile to OSX now, so if we could get one of those in tooltool we wouldn't need that hack.
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #7)
> That uname check is just a crappy hack to keep it from breaking the
> Taskcluster cross-compile builds :-/
>
> I assume between froydnj and rillian there's enough knowledge on how to
> package a Linux rustc that can cross-compile to OSX now, so if we could get
> one of those in tooltool we wouldn't need that hack.
Making the cross-compile case work is next on my list of things to do, once these patches and bug 1177599 land.
Comment 10•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/024b03bf16cf
https://hg.mozilla.org/mozilla-central/rev/d15e3e939643
https://hg.mozilla.org/mozilla-central/rev/9a2588391f4e
https://hg.mozilla.org/mozilla-central/rev/674873eba14b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•