Closed
Bug 1243312
Opened 9 years ago
Closed 9 years ago
Missing include nsNetCID.h
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: dragana, Assigned: dragana)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
jduell.mcbugs
:
review+
Sylvestre
:
approval-mozilla-esr45+
|
Details | Diff | Splinter Review |
With bug 905127 we un-inlining nsNetUtil.h.
I got a private e-mail informing that a build does not work if ac_add_options --enable-libproxy is set.
The error is:
.../firefox-43.0.3/toolkit/system/unixproxy/nsLibProxySettings.cpp: At global scope:
.../firefox-43.0.3/toolkit/system/unixproxy/nsLibProxySettings.cpp:129:5: error: 'NS_SYSTEMPROXYSETTINGS_CONTRACTID' was not declared in this scope
{ NS_SYSTEMPROXYSETTINGS_CONTRACTID, &kNS_UNIXSYSTEMPROXYSERVICE_CID },
So nsNetCID.h is missing
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8712586 -
Flags: review?(jduell.mcbugs)
|
||
Updated•9 years ago
|
Attachment #8712586 -
Flags: review?(jduell.mcbugs) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
status-firefox45:
--- → affected
status-firefox46:
--- → affected
status-firefox-esr45:
--- → affected
Comment on attachment 8712586 [details] [diff] [review]
bug_1243312.patch
[Approval Request Comment]
ESR consideration: Easier debugging downstream
User impact if declined: Broken build with --enable-libproxy
Fix Landed on Version: Firefox 47
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None
Attachment #8712586 -
Flags: approval-mozilla-esr45?
Keywords: regression
|
||
Updated•8 years ago
|
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8712586 [details] [diff] [review]
bug_1243312.patch
Simplify the life of packagers, taking it.
Attachment #8712586 -
Flags: approval-mozilla-esr45? → approval-mozilla-esr45+
|
||
Comment 6•8 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•