Closed
Bug 1243314
Opened 9 years ago
Closed 9 years ago
[porting][nexusplayer] add x86 32bits compiler option for Android toolchain
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: fatseng, Assigned: fatseng)
References
Details
Attachments
(1 file, 1 obsolete file)
When building gecko, it complains about
>/prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.8/bin/../lib/gcc/x86_64-linux-android/4.8/../../../../x86_64-linux-android/bin/ld: error: >/tmp/ccCxDPCj.o: incompatible target
>/home/farmer/works/nexusplayer-0113/out/target/product/fugu/obj/lib/crtbegin_dynamic.o:crtbrand.c:function _start: error: undefined reference >to 'main'
>collect2: error: ld returned 1 exit status
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → fatseng
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8712598 [details] [diff] [review]
add '-m32' compiler option for x86 32bits
Default of Android x86 4.8 tool chain(x86_64-linux-android-4.8) is for 64bits.
Therefore, need to add '-m32' compiler option for building x86 32bits
Attachment #8712598 -
Flags: review?(lissyx+mozillians)
|
||
Comment 3•9 years ago
|
||
That's a Gecko patch ?
|
|
||
Updated•9 years ago
|
Flags: needinfo?(fatseng)
|
|
||
Comment 4•9 years ago
|
||
Why not adding support for this in gonk-misc/default-gecko-config ?
|
|
Assignee | |
Comment 5•9 years ago
|
||
This is a Gecko patch.
I would try gonk-misc/default-gecko-config.
Flags: needinfo?(fatseng)
|
|
||
Updated•9 years ago
|
Attachment #8712598 -
Flags: review?(lissyx+mozillians)
|
|
Assignee | |
Comment 6•9 years ago
|
||
This patch works on Nexusplayer and not affect ARM
Attachment #8712598 -
Attachment is obsolete: true
Attachment #8713498 -
Flags: review?(lissyx+mozillians)
|
|
||
Comment 7•9 years ago
|
||
Comment on attachment 8713498 [details]
gonk-misc PR
See comment on github
Attachment #8713498 -
Flags: review?(lissyx+mozillians) → review+
|
|
Assignee | |
Comment 8•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #7)
> Comment on attachment 8713498 [details]
> gonk-misc PR
>
> See comment on github
Not only version change(4.7->4.8) but also name of toolchain.
Google replaced x86/i686-linux-android by x86/x86_64-linux-android from lollipop.
I will think a way to limit it.
|
|
Assignee | |
Comment 9•9 years ago
|
||
Comment on attachment 8713498 [details]
gonk-misc PR
I add toolchain prefix to limit it. Please help review patch again.
In order to support x86 64 bits, Google changed toolchain prefix from i686-linux-android to x86_64-linux-android.
I think restricting it is enough.
Attachment #8713498 -
Flags: review+ → review?(lissyx+mozillians)
|
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8713498 [details]
gonk-misc PR
Looks good to me but please add a comment to be clear about why.
Attachment #8713498 -
Flags: review?(lissyx+mozillians) → review+
|
|
Assignee | |
Comment 11•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #10)
> Comment on attachment 8713498 [details]
> gonk-misc PR
>
> Looks good to me but please add a comment to be clear about why.
I already add a comment.
Please help merge.
Flags: needinfo?(lissyx+mozillians)
|
|
||
Comment 12•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(lissyx+mozillians)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•