Closed Bug 1243604 Opened 9 years ago Closed 9 years ago

Use unused-local-typedefs instead of unused-local-typedef in the name of the warning for gcc 4.8 compat

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

Attachments

(1 file)

Use unused-local-typedefs instead of unused-local-typedef in the name of the warning for gcc 4.8 compat
(deleted), patch
Details | Diff | Splinter Review
Clang accepts both -Wunused-local-typedef and -Wunused-local-typedefs but gcc 4.8 only recognizes -Wunused-local-typedefs.
Blocks: gcc-4.8
I don't want to reject this on my own, but I think this is a mistake, and judging by bug 1117259 most interested people agree with that.
(In reply to Trevor Saunders (:tbsaunde) from comment #3) > I don't want to reject this on my own, but I think this is a mistake, and > judging by bug 1117259 most interested people agree with that. What do you mean by "this"? Fixing the name of the warning?
Flags: needinfo?(tbsaunde+mozbugs)
sfink says that fixing the atk warning was enough for him to build with 4.9.3 (modulo another problem unrelated to this specific warning). So I'm inclined to say we should not ignore this warning.
OK then someone needs to write that patch.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Attachment #8712973 - Flags: review?(mh+mozilla)
Flags: needinfo?(tbsaunde+mozbugs)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: