I have few systems which use the old sync and they're using a sync server which I host. All systems are windows and with different firefox versions (few run a release version of firefox, one aurora and one nightly). I also use a master password. As long as Firefox release was 43, they all synced fine. I then updated one of the 43 systems to 44, and at some stage noticed that it doesn't sync and after clicking the the sync button - it asks me to create an account or login. I then noticed that the saved logins button at the options/security panel pops an empty list. My logins.json file at the profile also seems quite empty: {"nextId":477,"logins":[],"disabledHosts":[],"version":1} rnewman suspected disk/FS failure. I had then tried to update my other two firefox 43 systems. On the first, I first observed the saved logins - which prompted me to enter my master password, and then correctly displayed my saved logins. I then opened the about box and it found the 44 update, which it then completed successfully and 44 now has the saved logins and sync works. On my other system, I started firefox, then it asked for my master password (presumably to start a sync) but I canceled it. Instead, I went to the about dialog, where it found the 44 update and I let it update it. After all was said and done, I ended up with 44 with my saved logins lost again, and logins.json emptied again (I did check it wasn't empty before the update). For the last system which exhibited the bug - I do have a backup of <user>/AppData/Roaming/Mozilla and of <user>/AppData/Local/Mozilla

Summary STR: * Open Firefox 43. Save passwords. * Enable MP. * Quit and relaunch. * Reject a MP dialog. * Update to 43 from within Firefox.

Justin, can you get this into the right triage funnel?

Do you have any of the prefs bug 1242176 comment 39 mentions set in the profile that hit this?

I'm not able to reproduce with the steps in comment 1.

(In reply to Richard Newman [:rnewman] from comment #1) > Summary STR: > > * Open Firefox 43. Save passwords. > * Enable MP. > * Quit and relaunch. > * Reject a MP dialog. > * Update to 43 from within Firefox. Note that last step should say "Update to 44" - I've not yet tried to repro myself.

I believe this is being addressed: https://bugzilla.mozilla.org/show_bug.cgi?id=1242176 A hotfix may be out tomorrow.

(In reply to Justin Dolske [:Dolske] from comment #3) > Do you have any of the prefs bug 1242176 comment 39 mentions set in the > profile that hit this? I don't recall touching any of these prefs manually via about:config in recent years. These are all the privacy.* lines which exist at prefs.js from the backup of the profile before I updated to 44 (which ended up with the saved logins gone after the update): user_pref("privacy.clearOnShutdown.cookies", false); user_pref("privacy.clearOnShutdown.passwords", true); user_pref("privacy.cpd.cookies", false); user_pref("privacy.cpd.downloads", false); user_pref("privacy.cpd.formdata", false); user_pref("privacy.cpd.history", false); user_pref("privacy.cpd.sessions", false); user_pref("privacy.donottrackheader.enabled", true); user_pref("privacy.sanitize.migrateFx3Prefs", true); user_pref("privacy.sanitize.timeSpan", 0); Also, I just noticed that after the update to 44 the "Remember logins for sites" checkbox is now unchecked (and obviously it was checked before the update).

(In reply to Avi Halachmi (:avih) from comment #7) > These are all the privacy.* lines which exist at prefs.js from the backup of > the profile before I updated to 44 (which ended up with the saved logins > gone after the update) ... So the rest are at their default value - and I don't know what these defaults are for 43.

Thanks for the update (In reply to Avi Halachmi (:avih) from comment #7) > user_pref("privacy.clearOnShutdown.passwords", true); and the default for privacy.sanitize.sanitizeOnShutdown is false, so yeah, this is bug 1242176.