Cynthia Tang [:cynthiatang] Reporter
	Description • 9 years ago

STR:
 1. Launch Browser app
 2. Go to Setting > Sign to Sync
 3. Try to input massive characters in accout field 

Actual Result:
 - The "x" button will cover the character. Please see the attachment.

Expected Result:
 - The "x" button will not cover the character


Device Mulet
Branch Master
Commit 87fb9a4c60793fad569894bd888cfbe0d36e294f
Merge: 6dfb1a8 8c256c8
Author: Luke Chang <luke-chang@users.noreply.github.com>
Date:   Mon Jan 18 12:15:38 2016 +0800

	Dan Huang[:danhuang] Assignee
	Comment 2 • 9 years ago

Comment on attachment 8713529 [details]
[gaia] danhuang1202:1244041_move_delete_button_out_of_input_field > mozilla-b2g:master

Hi Sean,
Please help review. This patch move the clear input button out of input field in fxa sign-in process. Thanks.

	Sean Lee [:seanlee][:weilonge]
	Comment 3 • 9 years ago

Comment on attachment 8713529 [details]
[gaia] danhuang1202:1244041_move_delete_button_out_of_input_field > mozilla-b2g:master

LGTM

	Dan Huang[:danhuang] Assignee
	Comment 4 • 9 years ago

Merge in master:
https://github.com/mozilla-b2g/gaia/commit/f0903c0d5208b7f497bf637f0801f3bd42401eb8

	Dan Huang[:danhuang] Assignee
	Comment 5 • 9 years ago

Comment on attachment 8713529 [details]
[gaia] danhuang1202:1244041_move_delete_button_out_of_input_field > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):Bug 1239346 
[User impact] if declined: The clear input button would overlap user input text
[Testing completed]:https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f16fd223d735b88669be1ba36ba8f8a6160fb200
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: None

	Josh Cheng [:josh]
	Comment 6 • 9 years ago

Comment on attachment 8713529 [details]
[gaia] danhuang1202:1244041_move_delete_button_out_of_input_field > mozilla-b2g:master

Approve for TV 2.5

	Cynthia Tang [:cynthiatang] Reporter
	Comment 8 • 9 years ago

Hi Cindy,
Could you please verify this issue? The resolution should be 1952x1141 in TV simulator. Thank you.

	Carsten Book [:Tomcat]
	Comment 9 • 9 years ago

https://github.com/mozilla-b2g/gaia/commit/477b7d717b6696663bca2e6003cbd9a8e82b9962

	cindylee
	Comment 10 • 9 years ago

(In reply to Cynthia Tang [:cynthiatang] from comment #8)
> Hi Cindy,
> Could you please verify this issue? The resolution should be 1952x1141 in TV
> simulator. Thank you.

Verified this issue on latest build with 1952x1141 resolution and check the issue is fixed.
[Build Info]
Environment: 2.6 simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/69a51cf5c8f23ea1f03679d698989dafd2ac4541
gecko:
https://hg.mozilla.org/mozilla-central/rev/d07dbd40dcd209124149f331f60dd55c8da33fbe

Thanks.

	cindylee
	Comment 11 • 8 years ago

This issue is verified on v2.5 and v2.6 latest build.
[Build Info]
2.6 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/5b90c09648798d8d66c4b08f81402b27acf0dc08
gecko:
https://hg.mozilla.org/mozilla-central/rev/05c087337043dd8e71cc27bdb5b9d55fd00aaa26

2.5 TV Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/81460a1025c357ca8a52e5bc8647fff6bb005638
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/240426e9718eab5661517e3f9ad6173819284615
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3