My TV build is broken after upgrading gecko to newer version, then I found that the patch for bug 1231042 breaks this. This happens because |nsScreenManagerGonk::SetCompositorVsyncScheduler| is set after |nsScreenManagerGonk::DisplayEnabled| is called.

I have a workaround by saving previous value, and set the value when the scheduler is given.

Comment on attachment 8713527 [details] [diff] [review] 0001-Bug-1244044-remember-display-status.patch Review of attachment 8713527 [details] [diff] [review]: ----------------------------------------------------------------- It's strange that we turn on the display before layer system ready. If we have that, we need to save the display status before setting the vsync scheduler.

Comment on attachment 8713527 [details] [diff] [review] 0001-Bug-1244044-remember-display-status.patch Review of attachment 8713527 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/gonk/nsScreenManagerGonk.cpp @@ -799,5 @@ > } > > void > nsScreenManagerGonk::DisplayEnabled(bool aEnabled) > { assert for main thread? @@ +1050,5 @@ > { > MOZ_ASSERT(NS_IsMainThread()); > > // We assume on b2g that there is only 1 CompositorParent > MOZ_ASSERT(mCompositorVsyncScheduler == nullptr); add a MOZ_ASSERT(aObserver) here. @@ +1052,5 @@ > > // We assume on b2g that there is only 1 CompositorParent > MOZ_ASSERT(mCompositorVsyncScheduler == nullptr); > mCompositorVsyncScheduler = aObserver; > + if (mCompositorVsyncScheduler) { Just call mCompositorVsyncScheduler->SetDisplay(mDisplayEnabled);

Comment on attachment 8720157 [details] [diff] [review] 0001-Bug-1244044-remember-display-status-r-jerry.patch Review of attachment 8720157 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/gonk/nsScreenManagerGonk.cpp @@ +813,1 @@ > } Please have a comment to show that we could call DisplayEnabled() before setting the CompositorVsyncScheduler.

add comment, carry r+

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a5348e0eaa2