Closed
Bug 1244412
Opened 9 years ago
Closed 9 years ago
Intermittent bug-1232386.js | Assertion failure: zone->runtimeFromAnyThread()->gc.nursery.isEmpty()
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: philor, Assigned: jonco)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
|
(deleted),
patch
|
terrence
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•9 years ago
|
||
The problem is that Zone::discardJitCode uses a ZoneCellIterUnderGC but can be called from AutoClearTypeInferenceStateOnOOM when not under a GC.
I think the easiest fix is to make ZoneCellIter work correctly whether called under a GC or not.
Assignee: nobody → jcoppeard
Attachment #8730668 -
Flags: review?(terrence)
|
|
Assignee | |
Comment 2•9 years ago
|
||
I'm in two minds about this because I like the documentation aspect of calling the 'UnderGC' version of the iterator, but there doesn't seem to be that much point in keeping it if ZoneCellIter works for both cases.
Attachment #8730669 -
Flags: review?(terrence)
|
||
Updated•9 years ago
|
Attachment #8730669 -
Flags: review?(terrence) → review+
|
|
||
Updated•9 years ago
|
Attachment #8730668 -
Flags: review?(terrence) → review+
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/51f649f844e1
https://hg.mozilla.org/mozilla-central/rev/a843f696dd44
https://hg.mozilla.org/mozilla-central/rev/3f07f0a72135
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
|
||
Comment 7•9 years ago
|
||
47 is marked as affected. Should this be uplifted?
Flags: needinfo?(jcoppeard)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Comment on attachment 8730668 [details] [diff] [review]
bug1244412-zone-cell-iter-fix
Approval Request Comment
[Feature/regressing bug #]: At the latest bug 1072564 but maybe earlier.
[User impact if declined]: Possible crash on OOM.
[Describe test coverage new/current, TreeHerder]: On m-c for over a month.
[Risks and why]: Low.
[String/UUID change made/needed]: None.
Flags: needinfo?(jcoppeard)
Attachment #8730668 -
Flags: approval-mozilla-aurora?
Comment on attachment 8730668 [details] [diff] [review]
bug1244412-zone-cell-iter-fix
OOM Crash fix, has been on Nightly48 for over a month, Beta47+
Attachment #8730668 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta+
|
||
Comment 10•9 years ago
|
||
| bugherder uplift | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•