Decision from the f2f to make cache .add() and .addAll() block not ok() responses. This will block opaque responses as a side effect: https://github.com/slightlyoff/ServiceWorker/issues/823#issuecomment-175320500 Note, google checked telemetry to verify opaque responses are not frequently stored in cache currently.

We need the new cache wpt test changes from blink before this can land. Mainly to avoid forcing blink to re-merge their test changes.

Comment on attachment 8715458 [details] [diff] [review] P4 Update cache wpt tests for new add()/addAll() behavior. r=ehsan Review of attachment 8715458 [details] [diff] [review]: ----------------------------------------------------------------- Note that these tests changes were provided by the blink team. I propose we just adopt them.

Try showed another devtools test that needs to get fixed. https://treeherder.mozilla.org/#/jobs?repo=try&revision=922de55e874a

Comment on attachment 8715455 [details] [diff] [review] P1 Make Cache .add()/.addAll() fail if a Response.ok() is false. r=ehsan Review of attachment 8715455 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/cache/Cache.cpp @@ +157,5 @@ > Fail(); > return; > } > > + // Do not all the convenience methods .add()/.addAll() to cache failed *call

I fixed the comment, although I meant "allow" instead of "call".

https://hg.mozilla.org/integration/mozilla-inbound/rev/d39088bf6b05 https://hg.mozilla.org/integration/mozilla-inbound/rev/fefb8f3312f2 https://hg.mozilla.org/integration/mozilla-inbound/rev/0517781f5ff7 https://hg.mozilla.org/integration/mozilla-inbound/rev/c9e84bd32396 https://hg.mozilla.org/integration/mozilla-inbound/rev/30210bbd013e

Comment on attachment 8715844 [details] [diff] [review] P1 Make Cache .add()/.addAll() fail if a Response.ok() is false. r=ehsan Approval Request Comment [Feature/regressing bug #]: Service Worker Cache API non-backward compatible change. [User impact if declined]: I would like to uplift this change so that it ships in the same timeframe as chrome. They indicate it will ship in April. Uplifting to 46 would result in us shipping in April as well. [Describe test coverage new/current, TreeHerder]: Tests included. The wpt test patch will need to be rebased for aurora. [Risks and why]: Minimal, only affects cache API. [String/UUID change made/needed]: None

Comment on attachment 8715456 [details] [diff] [review] P2 Make dom/cache mochitests pass with new add()/addAll() behavior. r=ehsan See comment 12.

Comment on attachment 8715457 [details] [diff] [review] P3 Make service worker tests pass with new Cache add()/addAll() behavior. r=ehsan See comment 12.

Comment on attachment 8715507 [details] [diff] [review] P5 Fix devtools test to work with new Cache add()/addAll() behavior. r=ehsan See comment 12.

See comment 12.

https://hg.mozilla.org/mozilla-central/rev/d39088bf6b05 https://hg.mozilla.org/mozilla-central/rev/fefb8f3312f2 https://hg.mozilla.org/mozilla-central/rev/0517781f5ff7 https://hg.mozilla.org/mozilla-central/rev/c9e84bd32396 https://hg.mozilla.org/mozilla-central/rev/30210bbd013e

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/cache-api-now-rejects-unsuccessful-responses/

I've noted this in an exceptions table on https://developer.mozilla.org/en-US/docs/Web/API/Cache/add https://developer.mozilla.org/en-US/docs/Web/API/Cache/addAll And added a line to the browser compat tables to make it clear what version this change is available in. Is that ok?

Tracking this for 46+ since we're aiming this feature at 46.

Comment on attachment 8715844 [details] [diff] [review] P1 Make Cache .add()/.addAll() fail if a Response.ok() is false. r=ehsan SW changes aimed at 46, includes tests. OK to uplift to aurora.

I'm hitting conflicts uplifting part 5. Looks like you'll need to rebase around the lack of bug 1003860.

Since bug 1003860 is not in aurora, we don't need the P5 patch at all. That devtools test isn't using cache API. I went ahead and landed. remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/26c22e6b4ef5 remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/93b6cbe48abd remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/1689beaabd59 remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/bafa23fb5915