Matt Woodrow (:mattwoodrow) Reporter
	Description • 8 years ago

Bug 1229317 is making this code bail out from it's attempts to minimize the visible region if any children have preserve-3d.

We should be able to handle these layers properly, probably by passing a reference to the visible region being accumulated for the ancestor of the preserve-3d tree down to the leaves and transforming by the accumulated transform.

	Thinker Li [:sinker] Assignee
	Comment 2 • 8 years ago

Comment on attachment 8716248 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d

This patch treat a layers on the path to the root of a 3D rendering context as a giant layer.  So, it skips all intermediate layers, and use accumulated transforms for the leaves of 3d rendering context.

	Matt Woodrow (:mattwoodrow) Reporter
	Comment 3 • 8 years ago

Comment on attachment 8716248 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d

Review of attachment 8716248 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, this is exactly what I had in mind!

End up being simpler than I imagined too, thanks for doing this.

	Thinker Li [:sinker] Assignee
	Comment 4 • 8 years ago

--
Attachment #8716248 [details] [diff] - Attachment is obsolete: true

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 5 • 8 years ago

Looks like this may not have landed yet. It should probably get uplift to aurora 46 as well once it is on m-c for a bit.

	Pulsebot
	Comment 6 • 8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4dd7869c4f

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 7 • 8 years ago

Landed to aurora:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d4dd7869c4f

Will leave the uplift request to matt and :sinker

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 8 • 8 years ago

Er, landed to *inbound*.

	Thinker Li [:sinker] Assignee
	Comment 9 • 8 years ago

Comment on attachment 8720088 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d, v2

Approval Request Comment
[Feature/regressing bug #]: 1244943
[User impact if declined]: With incorrect visible region of layers, screen repainting is potentially wrong.
[Describe test coverage new/current, TreeHerder]:
Testcases of layer tree invalidation would cover this change.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9980d741547c
[Risks and why]: 
Low risk because it does not effect other features, and the change is limited in a small block in a function.
[String/UUID change made/needed]: none

	Carsten Book [:Tomcat]
	Comment 10 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/4d4dd7869c4f

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 11 • 8 years ago

Marking affected for 46, tracking as this is a regression from the preserve-3d changes

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 12 • 8 years ago

Comment on attachment 8720088 [details] [diff] [review]
Make PostProcessLayers aware of preserve-3d, v2

Should help with preserve-3d changes, please uplift to aurora.

	Carsten Book [:Tomcat]
	Comment 13 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/31c2798b51d5