Closed
Bug 1245033
Opened 9 years ago
Closed 9 years ago
Build break in dom/system/gonk/GonkGPSGeolocationProvider.cpp:541:126: error: format '%d' expects argument of type 'int', but argument 5 has type 'nsresult'
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox45 fixed, firefox46 fixed, firefox47 fixed)
RESOLVED
FIXED
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
Attachments
(1 file)
(deleted),
patch
|
fabrice
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
I am seeing this error on treeherder https://treeherder.mozilla.org/logviewer.html#?job_id=20887426&repo=mozilla-inbound
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → ferjmoreno
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b38e07d9bd81
Assignee | ||
Updated•9 years ago
|
Attachment #8714702 -
Flags: review?(fabrice)
Updated•9 years ago
|
Attachment #8714702 -
Flags: review?(fabrice) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8714702 [details] [diff] [review] v1 From https://bugzilla.mozilla.org/show_bug.cgi?id=1237831#c25 Approval Request Comment [Feature/regressing bug #]: Bug 1237831 [User impact if declined]: B2G builds are busted [Risks and why]: Very low risk, just a typecast on an error message to make the build pass. [String/UUID change made/needed]: None
Attachment #8714702 -
Flags: approval-mozilla-beta?
Attachment #8714702 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
Why this needs an uplift to beta?
Assignee | ||
Comment 6•9 years ago
|
||
Because the patch causing this build regression is on Beta: https://bugzilla.mozilla.org/show_bug.cgi?id=1237831#c25
Comment 7•9 years ago
|
||
Comment on attachment 8714702 [details] [diff] [review] v1 OK, thanks. Let's take it then! Should be in 45 beta 3.
Attachment #8714702 -
Flags: approval-mozilla-beta?
Attachment #8714702 -
Flags: approval-mozilla-beta+
Attachment #8714702 -
Flags: approval-mozilla-aurora?
Attachment #8714702 -
Flags: approval-mozilla-aurora-
Comment 8•9 years ago
|
||
Comment on attachment 8714702 [details] [diff] [review] v1 oups, not yet in in m-c
Attachment #8714702 -
Flags: approval-mozilla-beta?
Attachment #8714702 -
Flags: approval-mozilla-beta+
Attachment #8714702 -
Flags: approval-mozilla-aurora?
Attachment #8714702 -
Flags: approval-mozilla-aurora-
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/abfc4b8a1d92
Updated•9 years ago
|
Attachment #8714702 -
Flags: approval-mozilla-beta?
Attachment #8714702 -
Flags: approval-mozilla-beta+
Attachment #8714702 -
Flags: approval-mozilla-aurora?
Attachment #8714702 -
Flags: approval-mozilla-aurora+
Comment 10•9 years ago
|
||
has problems uplifting to aurora and beta like: grafting 326784:abfc4b8a1d92 "Bug 1245033 - Build break in dom/system/gonk/GonkGPSGeolocationProvider.cpp:541:126: error: format '%d' expects argument of type 'int', but argument 5 has type 'nsresult'. r=fabrice" merging dom/system/gonk/GonkGPSGeolocationProvider.cpp warning: conflicts while merging dom/system/gonk/GonkGPSGeolocationProvider.cpp! (edit, then use 'hg resolve --mark') abort: unresolved conflicts, can't continue
Flags: needinfo?(ferjmoreno)
Comment 12•9 years ago
|
||
remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/f19a31a82ae3
status-firefox46:
--- → fixed
Comment 13•9 years ago
|
||
remote: https://hg.mozilla.org/releases/mozilla-beta/rev/ffb9c10f484b
status-firefox45:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•