Closed Bug 1245033 Opened 9 years ago Closed 9 years ago

Build break in dom/system/gonk/GonkGPSGeolocationProvider.cpp:541:126: error: format '%d' expects argument of type 'int', but argument 5 has type 'nsresult'

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox45 fixed, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file)

Blocks: 1237831
Attached patch v1 (deleted) — Splinter Review
Assignee: nobody → ferjmoreno
Attachment #8714702 - Flags: review?(fabrice)
Attachment #8714702 - Flags: review?(fabrice) → review+
Comment on attachment 8714702 [details] [diff] [review]
v1

From https://bugzilla.mozilla.org/show_bug.cgi?id=1237831#c25

Approval Request Comment
[Feature/regressing bug #]: Bug 1237831
[User impact if declined]: B2G builds are busted
[Risks and why]: Very low risk, just a typecast on an error message to make the build pass.
[String/UUID change made/needed]: None
Attachment #8714702 - Flags: approval-mozilla-beta?
Attachment #8714702 - Flags: approval-mozilla-aurora?
Why this needs an uplift to beta?
Because the patch causing this build regression is on Beta: https://bugzilla.mozilla.org/show_bug.cgi?id=1237831#c25
Comment on attachment 8714702 [details] [diff] [review]
v1

OK, thanks. Let's take it then!
Should be in 45 beta 3.
Attachment #8714702 - Flags: approval-mozilla-beta?
Attachment #8714702 - Flags: approval-mozilla-beta+
Attachment #8714702 - Flags: approval-mozilla-aurora?
Attachment #8714702 - Flags: approval-mozilla-aurora-
Comment on attachment 8714702 [details] [diff] [review]
v1

oups, not yet in in m-c
Attachment #8714702 - Flags: approval-mozilla-beta?
Attachment #8714702 - Flags: approval-mozilla-beta+
Attachment #8714702 - Flags: approval-mozilla-aurora?
Attachment #8714702 - Flags: approval-mozilla-aurora-
Blocks: 1245091
https://hg.mozilla.org/mozilla-central/rev/abfc4b8a1d92
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #8714702 - Flags: approval-mozilla-beta?
Attachment #8714702 - Flags: approval-mozilla-beta+
Attachment #8714702 - Flags: approval-mozilla-aurora?
Attachment #8714702 - Flags: approval-mozilla-aurora+
has problems uplifting to aurora and beta like:

grafting 326784:abfc4b8a1d92 "Bug 1245033 - Build break in dom/system/gonk/GonkGPSGeolocationProvider.cpp:541:126: error: format '%d' expects argument of type 'int', but argument 5 has type 'nsresult'. r=fabrice"
merging dom/system/gonk/GonkGPSGeolocationProvider.cpp
warning: conflicts while merging dom/system/gonk/GonkGPSGeolocationProvider.cpp! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
Flags: needinfo?(ferjmoreno)
I'll sort this out.
Flags: needinfo?(ferjmoreno)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: