Closed
Bug 1245055
Opened 9 years ago
Closed 9 years ago
Remove workarounds for assembly using r7 on thumb
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8714734 -
Flags: review?(mshal)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8714735 -
Flags: review?(mshal)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8714734 [details] [diff] [review]
Remove toolkit/crashreporter/google-breakpad/src/client/linux/handler/Makefile.in
This seems reasonable. How many times did you test it? I can't tell from bug 633436 how inconsistent the original error was, and the comment just says that it "complains inconsistently". I guess if it's still an issue we'd find out pretty quickly and can add the flag to moz.build
Attachment #8714734 -
Flags: review?(mshal) → review+
|
|
||
Updated•9 years ago
|
Attachment #8714735 -
Flags: review?(mshal) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
Yeah, I don't know what the "inconsistently" is supposed to mean, but I see no reason why the compiler would complain randomly. Either it does or it does not. And it does not in any of the android arm builds, opt of debug, with or without profiling enabled. So...
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5598f6f12520
https://hg.mozilla.org/mozilla-central/rev/82adb48a15e7
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•