Closed
Bug 124517
Opened 23 years ago
Closed 23 years ago
Double deletes happen because we can make more than one nsMacMemoryCushion
Categories
(Core :: XUL, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: sfraser_bugs, Assigned: sfraser_bugs)
References
Details
Attachments
(1 file)
(deleted),
patch
|
beard
:
review+
beard
:
superreview+
|
Details | Diff | Splinter Review |
We've always worked under the assumption that the nsAppShell in Mac widget code
is a singleton, and thus given it ownership of the nsMacMemoryCushion.
However, we can create multiple nsAppShell objects, since we make one for each
nested event loop (e.g. modal dialogs, including the profile picker). This means
that we can instantiate > 1 nsMacMemoryCushion, each of which install a
GrowZoneProc, and dispose the buffer handle in their dtors .This is bad.
Assignee | ||
Updated•23 years ago
|
Severity: normal → critical
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.9
Assignee | ||
Comment 1•23 years ago
|
||
Comment 2•23 years ago
|
||
Nit: softFluffyCusion? Don't you want a softFluffyCushion? And the whitespace
in nsAppShell::Create() seems off. Other than that, r=sdagley
Assignee | ||
Comment 3•23 years ago
|
||
I've been having a bad speling day today
Assignee | ||
Comment 4•23 years ago
|
||
*** Bug 106283 has been marked as a duplicate of this bug. ***
Comment 6•23 years ago
|
||
Comment on attachment 68679 [details] [diff] [review]
Patch to ensure that nsMemoryCusion is a singleton
sr=beard (r=sdagley already)
same nits...
Attachment #68679 -
Flags: superreview+
Attachment #68679 -
Flags: review+
Comment 7•23 years ago
|
||
*** Bug 114907 has been marked as a duplicate of this bug. ***
Comment 8•23 years ago
|
||
what does introducting
+std::auto_ptr<nsMacMemoryCushion> gMemoryCusion;
do to embedding clients? Will this ever get released? Doesn't seem to play nice.'
Assignee | ||
Comment 9•23 years ago
|
||
+std::auto_ptr<nsMacMemoryCushion> gMemoryCusion;
The delete will happen at library unload time, which seems correct.
Assignee | ||
Comment 10•23 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•23 years ago
|
||
*** Bug 93458 has been marked as a duplicate of this bug. ***
Comment 12•23 years ago
|
||
*** Bug 121664 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•