Closed
Bug 1245408
Opened 9 years ago
Closed 9 years ago
[TV][Seamless experience] ESC to Backspace (Keyboard event change)
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
blocking-b2g | 2.5+ |
People
(Reporter: cynthiatang, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices][partner-cherry-pick][partner-blocker])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
rexboy
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details |
STR:
1. Sent Tab to TV
2. Press Back (Backspace key)
Expect result:
- The video will pause and ask if user want to leave.
- Dialog Body: Do you want to end video playback?
Actual Result:
- Nothing happened
======================
Build ID 20160201030209
Gaia Revision 10df3a68103c4ae7bd033eb0a742deb59c01b3bf
Gaia Date 2016-02-02 19:13:16
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/941033a51983ddec2d99aa9f868a54c0196a4075
Gecko Version 46.0a1
Device Name hammerhead
Firmware(Release) 5.1.1
Firmware(Incremental) eng.cltbld.20160201.063447
Firmware Date Mon Feb 1 06:35:05 EST 2016
Bootloader HHZ12f
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(fliu)
Reporter | ||
Updated•9 years ago
|
QA Whiteboard: [COM=TV Seamless Experience]
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → affected
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8715209 [details]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master
@rex,
The patch changes to the newly updated 'back-keyup' event in the KeyNavigationAdapter, thank you
Flags: needinfo?(fliu)
Attachment #8715209 -
Flags: review?(rexboy)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → fliu
Assignee | ||
Updated•9 years ago
|
Whiteboard: [ft:conndevices] → [ft:conndevices][partner-cherry-pick][partner-blocker]
Assignee | ||
Comment 3•9 years ago
|
||
[Blocking Requested - why for this release]:
blocking-b2g: --- → 2.5?
Comment 4•9 years ago
|
||
Comment on attachment 8715209 [details]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master
So did you confirmed that we are not going to use esc for quitting anymore? If yes you can land it.
Attachment #8715209 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8715209 [details]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1245408
[User impact] if declined: Unable to end video when pressing back key
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No
Attachment #8715209 -
Flags: approval-gaia-v2.5?(jocheng)
Comment 7•9 years ago
|
||
Comment on attachment 8715209 [details]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master
Approved for TV 2.5
Attachment #8715209 -
Flags: approval-gaia-v2.5?(jocheng) → approval-gaia-v2.5+
Updated•9 years ago
|
blocking-b2g: 2.5? → 2.5+
Comment 8•9 years ago
|
||
Reporter | ||
Comment 9•9 years ago
|
||
Verified on v2.5 and Master
Master
Serial: 0688039f439c66e4 (State: device)
Build ID 20160223150255
Gaia Revision e0c9692073da86f91b348b1527dda1bbfc2f404b
Gaia Date 2016-02-23 21:06:20
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
Gecko Version 47.0a1
Device Name hammerhead
Firmware(Release) 5.1.1
Firmware(Incremental) eng.cltbld.20160223.200438
Firmware Date Tue Feb 23 20:04:56 EST 2016
Bootloader HHZ12f
v2.5
Build ID 20160223150255
Gaia Revision b059a19c4cb615e16174735662199e6769cee393
Gaia Date 2016-02-23 15:29:43
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
Gecko Version 47.0a1
Device Name hammerhead
Firmware(Release) 5.1.1
Firmware(Incremental) eng.cltbld.20160223.200438
Firmware Date Tue Feb 23 20:04:56 EST 2016
Bootloader HHZ12f
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•