Closed
Bug 1245414
Opened 9 years ago
Closed 9 years ago
Sync up MFBT's Decimal class with the upstream code
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(11 files)
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8715191 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8715193 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8715195 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8715197 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8715199 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8715200 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8715201 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8715202 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8715294 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 12•9 years ago
|
||
Our tests seem to all pass on Try, despite a decent amount of unrelated orange:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c77d6560428c
Updated•9 years ago
|
Attachment #8715191 -
Flags: review?(jwalden+bmo) → review+
Comment 13•9 years ago
|
||
Comment on attachment 8715193 [details] [diff] [review]
part 2 - Update mfbt/decimal/update.sh to reflect Blink's switch from svn to git, and the different files we now pull
Review of attachment 8715193 [details] [diff] [review]:
-----------------------------------------------------------------
::: mfbt/decimal/update.sh
@@ +40,4 @@
> for F in "${FILES[@]}"
> do
> + printf "Downloading `basename $F`..."
> + curl "$REPO_PATH/${F}?format=TEXT" | base64 -D > "$F"
We should think about dumping git hash in a sibling file or something, so we know the exact base rev we imported. Just like intl/icu/SVN-INFO exists. Separate patch? Don't care about formatting or anything, just want *something* recording the info.
Attachment #8715193 -
Flags: review?(jwalden+bmo) → review+
Comment 14•9 years ago
|
||
Comment on attachment 8715195 [details] [diff] [review]
part 3 - Overwrite mfbt/decimal/Decimal.* with vanilla upstream copies
Review of attachment 8715195 [details] [diff] [review]:
-----------------------------------------------------------------
Psh, we don't need no stinkin' changes!
Attachment #8715195 -
Flags: review?(jwalden+bmo) → review+
Comment 15•9 years ago
|
||
Comment on attachment 8715197 [details] [diff] [review]
part 4 - Update mfbt/decimal/zero-serialization.patch
Review of attachment 8715197 [details] [diff] [review]:
-----------------------------------------------------------------
...or maybe we do. ;-)
Attachment #8715197 -
Flags: review?(jwalden+bmo) → review+
Updated•9 years ago
|
Attachment #8715199 -
Flags: review?(jwalden+bmo) → review+
Updated•9 years ago
|
Attachment #8715200 -
Flags: review?(jwalden+bmo) → review+
Comment 16•9 years ago
|
||
Comment on attachment 8715201 [details] [diff] [review]
part 7 - Update mfbt/decimal/to-moz-dependencies.patch
Review of attachment 8715201 [details] [diff] [review]:
-----------------------------------------------------------------
::: mfbt/decimal/to-moz-dependencies.patch
@@ +126,5 @@
>
> +/**
> + * Imported from:
> ++ * https://chromium.googlesource.com/chromium/src.git/+/master/third_party/WebKit/Source/platform/Decimal.h
> ++ * Check hg log for the date of the last update from Blink core.
Frowny-face!
Attachment #8715201 -
Flags: review?(jwalden+bmo) → review+
Updated•9 years ago
|
Attachment #8715202 -
Flags: review?(jwalden+bmo) → review+
Updated•9 years ago
|
Attachment #8715294 -
Flags: review?(jwalden+bmo) → review+
Comment 17•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d669d419453
https://hg.mozilla.org/integration/mozilla-inbound/rev/f2b2fdf5b0b2
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1ca6010b131
https://hg.mozilla.org/integration/mozilla-inbound/rev/9da84cc6a236
https://hg.mozilla.org/integration/mozilla-inbound/rev/4929064f96e0
https://hg.mozilla.org/integration/mozilla-inbound/rev/678d101c5d60
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c730fc39712
https://hg.mozilla.org/integration/mozilla-inbound/rev/54a485b76667
https://hg.mozilla.org/integration/mozilla-inbound/rev/37a35e3c6648
https://hg.mozilla.org/integration/mozilla-inbound/rev/5626cc714fb1
Assignee | ||
Comment 18•9 years ago
|
||
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #13)
> Comment on attachment 8715193 [details] [diff] [review]
> part 2 - Update mfbt/decimal/update.sh to reflect Blink's switch from svn to
> git, and the different files we now pull
>
> We should think about dumping git hash in a sibling file or something, so we
> know the exact base rev we imported. Just like intl/icu/SVN-INFO exists.
> Separate patch? Don't care about formatting or anything, just want
> *something* recording the info.
I've made update.sh dump out the SHA to a new file called UPSTREAM-GIT-SH.
(In reply to Jeff Walden [:Waldo] (remove +bmo to email) from comment #16)
> Comment on attachment 8715201 [details] [diff] [review]
> part 7 - Update mfbt/decimal/to-moz-dependencies.patch
>
> > ++ * Check hg log for the date of the last update from Blink core.
>
> Frowny-face!
And updated this comment to reflect that.
Comment 19•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8d669d419453
https://hg.mozilla.org/mozilla-central/rev/f2b2fdf5b0b2
https://hg.mozilla.org/mozilla-central/rev/d1ca6010b131
https://hg.mozilla.org/mozilla-central/rev/9da84cc6a236
https://hg.mozilla.org/mozilla-central/rev/4929064f96e0
https://hg.mozilla.org/mozilla-central/rev/678d101c5d60
https://hg.mozilla.org/mozilla-central/rev/3c730fc39712
https://hg.mozilla.org/mozilla-central/rev/54a485b76667
https://hg.mozilla.org/mozilla-central/rev/37a35e3c6648
https://hg.mozilla.org/mozilla-central/rev/5626cc714fb1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•