Closed
Bug 1245641
Opened 9 years ago
Closed 9 years ago
Implement chrome.downloads.erase()
Categories
(WebExtensions :: Untriaged, defect)
WebExtensions
Untriaged
Tracking
(firefox48 fixed)
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: aswan, Assigned: aswan)
References
(Blocks 1 open bug)
Details
(Whiteboard: [downloads])
Attachments
(1 file)
Part of supporting chrome.downloads in WebExtensions
https://developer.chrome.com/extensions/downloads#method-erase
Updated•9 years ago
|
Whiteboard: [downloads]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → aswan
Iteration: --- → 48.1 - Mar 21
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/40121/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40121/
Attachment #8730726 -
Flags: review?(kmaglione+bmo)
Comment 2•9 years ago
|
||
Comment on attachment 8730726 [details]
MozReview Request: Bug 1245641 Implement chrome.downloads.erase() r?kmag
https://reviewboard.mozilla.org/r/40121/#review36661
::: toolkit/components/extensions/schemas/downloads.json:712
(Diff revision 1)
> + "type": "number"
> + },
> + "exists": {
> + "type": "boolean",
> + "optional": true
> }
Can we add a type for this, and use it for both `.search()` and `.erase()`?
Attachment #8730726 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/40121/#review36661
> Can we add a type for this, and use it for both `.search()` and `.erase()`?
I thought about that, but if we generate docs from the schema, then the unified type will show up and our docs will appear to be different from Chrome's even when we're really identical (in this area anyway). I could well be overthinking it, is that not a concern?
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/40121/#review36661
> I thought about that, but if we generate docs from the schema, then the unified type will show up and our docs will appear to be different from Chrome's even when we're really identical (in this area anyway). I could well be overthinking it, is that not a concern?
I'm not expecting to generate docs from the schema again any time soon, but even if we do, I wouldn't worry about them looking different from Chrome's. If anything, I think it should make the documentation clearer.
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8730726 [details]
MozReview Request: Bug 1245641 Implement chrome.downloads.erase() r?kmag
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40121/diff/1-2/
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 6•9 years ago
|
||
has problems to apply:
Hunk #3 FAILED at 469
Hunk #4 FAILED at 573
2 out of 4 hunks FAILED -- saving rejects to file toolkit/components/extensions/ext-downloads.js.rej
patching file toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_misc.html
Hunk #1 FAILED at 459
1 out of 1 hunks FAILED -- saving rejects to file toolkit/components/extensions/test/mochitest/test_chrome_ext_downloads_misc.html.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue
Flags: needinfo?(aswan)
Keywords: checkin-needed
Assignee | ||
Comment 7•9 years ago
|
||
I was able to rebase cleanly onto fx-team, should I be using something else?
Flags: needinfo?(aswan) → needinfo?(cbook)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8730726 [details]
MozReview Request: Bug 1245641 Implement chrome.downloads.erase() r?kmag
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40121/diff/2-3/
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8730726 [details]
MozReview Request: Bug 1245641 Implement chrome.downloads.erase() r?kmag
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40121/diff/3-4/
Assignee | ||
Comment 10•9 years ago
|
||
Rebased onto the very latest fx-team
Flags: needinfo?(cbook)
Keywords: checkin-needed
Comment 11•9 years ago
|
||
Keywords: checkin-needed
Comment 12•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•