Comment on attachment 8717724 [details] [diff] [review] utility for obtaining platform information Review of attachment 8717724 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/extensions/ExtensionUtils.jsm @@ +935,5 @@ > function flushJarCache(jarFile) { > Services.obs.notifyObservers(jarFile, "flush-cache-entry", null); > } > > +function getPlatformInfo() { I'd rather avoid defining this function if it's only ever going to be used once. We could just define `PlatformInfo`, create a block scope and define the `os` and `arch` properties from that, and then freeze the `PlatformInfo` object. Or we could generate it from an immediately invoking function expression. @@ +952,5 @@ > + > + return {os, arch}; > +} > + > +const PlatformInfo = getPlatformInfo(); This should probably be `Object.freeze(getPlatformInfo())` if we're going to export it.

hi, this failed to apply: patching file toolkit/components/extensions/ext-runtime.js Hunk #1 FAILED at 0 1 out of 2 hunks FAILED -- saving rejects to file toolkit/components/extensions/ext-runtime.js.rej