comma-spacing enforces having spaces after commas (not before etc). semi enforces semicolons at the end of statements.

Review commit: https://reviewboard.mozilla.org/r/35467/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/35467/

Comment on attachment 8720784 [details] MozReview Request: Bug 1246365 - Enable eslint "comma-spacing" and "semi" rules for PSM. r=keeler https://reviewboard.mozilla.org/r/35467/#review32197 Great - LGTM with comment about braces addressed. ::: security/manager/pki/resources/content/certpicker.js:56 (Diff revision 1) > -function doOK() > +function doOK() { This brace placement seems inconsistent with the rest of this file. Should we defer these changes to if/when we enable a rule that applies to these braces? ::: security/manager/pki/resources/content/choosetoken.js:29 (Diff revision 1) > -function doOK() > +function doOK() { Same here, etc.

https://reviewboard.mozilla.org/r/35467/#review32197 Thanks for the review! > This brace placement seems inconsistent with the rest of this file. Should we defer these changes to if/when we enable a rule that applies to these braces? I deferred the brace changes. My original plan was to make the changes here to save some future review. However, it looks moving the braces here doesn't make a huge difference, and I'm wavering on whether we should even bother turning on the rule.

Comment on attachment 8720784 [details] MozReview Request: Bug 1246365 - Enable eslint "comma-spacing" and "semi" rules for PSM. r=keeler Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35467/diff/1-2/