Closed Bug 1246366 Opened 9 years ago Closed 8 years ago

LocalStorage inspector, scrolling is extremely slow

Categories

(DevTools :: Storage Inspector, defect, P3)

46 Branch
defect

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: eelco, Assigned: miker)

References

()

Details

(Keywords: perf, regression, testcase)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:44.0) Gecko/20100101 Firefox/44.0 Build ID: 20160123151951 Steps to reproduce: -Load a page that creates many LocalStorage items (e.g. the test URL provided). -Open LocalStorage inspector. Actual results: Scrolling the inspector is extremely slow, hangs the UI, and may even lead to "unresponsive script" warnings. Expected results: No "unresponsive script" warnings should appear, and scrolling should be smooth.
This may be related/similar to the issues during tests of bug 1171903?
Component: Untriaged → Developer Tools: Storage Inspector
Blocks: 1171903
Status: UNCONFIRMED → NEW
Ever confirmed: true
We have added paging since you created this bug. Does it work okay for you using the latest version of Firefox?
Flags: needinfo?(ev548)
Priority: -- → P3
Using developer edition 49.0a2 as of July 3. Endless scrolling has disappeared; only a fixed number of (random) entries are shown. All other entries are inaccessible using the storage inspector. (Obviously, scrolling is not slow.)
Flags: needinfo?(ev548)
This appears to work fine since adding natural sort. @ev548: Can you confirm this?
Assignee: nobody → mratcliffe
Flags: needinfo?(ev548)
(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4) > This appears to work fine since adding natural sort. > > @ev548: Can you confirm this? Not with Nightly 55.0a1 (2017-05-02) (64-bit) on MacOS. Is this the right version to test with? Using this version I get "beach balls" whenever scrolling past the current bottom. This even leads to "Warning: unresponsive script" popups.
Flags: needinfo?(ev548)
(In reply to ev548 from comment #5) > (In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #4) > > This appears to work fine since adding natural sort. > > > > @ev548: Can you confirm this? > > Not with Nightly 55.0a1 (2017-05-02) (64-bit) on MacOS. Is this the right > version to test with? > Yes, that is the right version. > Using this version I get "beach balls" whenever scrolling past the current > bottom. This even leads to "Warning: unresponsive script" popups. This is where we are transferring the cookie information from privileged to unprivileged JS. I am also on OSX and am surprised that you are getting the unresponsive script popup. There is only a small delay for me, which is to be expected.
How many entries in localStorage did you test with? I typically have a few hundred, perhaps up to 2000 entries, each consisting of a text string of, say, 100 characters in length. Could that explain the behaviour that I'm seeing?
Maybe, can you attach your testcase?
My original testcase (URL provided above, as part of the bug details, now indeed works. Perhaps not super-smooth, but definitely well enough for daily use. Thanks! I adapted that testcase a bit. I don't know how to attach a second URL, but it is http://wwwhome.ewi.utwente.nl/~vriezekolke/test3.html This generates longer strings. With some scrolling up & down am I able to trigger beachballs/hourglass, but also the "unresponsive script" popup. I don't know whether we should pursue this up to perfection. This solution definitely helps me, a lot. My testcase (and web-app) are perhaps a bit too extreme or inefficient, and the browser cannot be blamed for that. I consider this solved. Again, thanks!
(In reply to ev548 from comment #9) > My original testcase (URL provided above, as part of the bug details, now > indeed works. Perhaps not super-smooth, but definitely well enough for daily > use. Thanks! > I adapted that testcase a bit. I don't know how to attach a second URL, but > it is > http://wwwhome.ewi.utwente.nl/~vriezekolke/test3.html > This generates longer strings. With some scrolling up & down am I able to > trigger beachballs/hourglass, but also the "unresponsive script" popup. > I don't know whether we should pursue this up to perfection. This solution > definitely helps me, a lot. My testcase (and web-app) are perhaps a bit too > extreme or inefficient, and the browser cannot be blamed for that. > I consider this solved. Again, thanks! I thing this is enough of an edge case for us not to worry about and as the original issue is fixed so I agree that this is solved.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.