Closed
Bug 1246549
Opened 9 years ago
Closed 9 years ago
Respect ALLOW_COMPILER_WARNINGS when deciding whether to build NSS with warnings as errors
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1243233
People
(Reporter: ehsan.akhgari, Unassigned)
References
Details
Attachments
(1 file)
The reason why this matters is that ALLOW_COMPILER_WARNINGS takes things
such as whether we're building with clang-cl into account.
|
Reporter | |
Comment 1•9 years ago
|
||
Attachment #8716840 -
Flags: review?(mh+mozilla)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8716840 [details] [diff] [review]
Respect ALLOW_COMPILER_WARNINGS when deciding whether to build NSS with warnings as errors
Review of attachment 8716840 [details] [diff] [review]:
-----------------------------------------------------------------
I reviewed a very similar patch in bug 1243233. See comments there. And see with sfink if you want to steal it from him.
Attachment #8716840 -
Flags: review?(mh+mozilla)
|
|
Reporter | |
Comment 3•9 years ago
|
||
This can wait, I think these are essentially the same patches!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•