Closed
Bug 1246850
Opened 9 years ago
Closed 9 years ago
Missing check for return code in call to NotifyIpInterfaceChange
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: bugzilla, Assigned: bagder)
Details
(Keywords: crash, Whiteboard: [44dll][necko-active])
Crash Data
Attachments
(1 file)
(deleted),
patch
|
mcmanus
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
Sylvestre
:
approval-mozilla-release-
|
Details | Diff | Splinter Review |
We're not checking the return code from NotifyIpInterfaceChange, resulting in us potentially passing a bad handle to CancelMibChangeNotify2.
I'm trying to eliminate possible triggers of crash stacks such as:
https://crash-stats.mozilla.com/report/index/889b5884-fdbe-43c2-800d-2984f2160201
and this one look like a candidate. Yes, it has been in the code longer than 44, but nonetheless...
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(daniel)
Assignee | ||
Comment 1•9 years ago
|
||
Ack. Patch pending.
Assignee: nobody → daniel
Component: Networking: DNS → Networking
Flags: needinfo?(daniel)
Assignee | ||
Comment 2•9 years ago
|
||
Check the return code from NotifyIpInterfaceChange(). It probably indicates a pretty serious error somewhere if it returns error here - but right now this will only log about it to avoid crashes and return.
Attachment #8717357 -
Flags: review?(mcmanus)
Updated•9 years ago
|
Attachment #8717357 -
Flags: review?(mcmanus) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Keywords: checkin-needed
Keywords: checkin-needed
Updated•9 years ago
|
Whiteboard: [44dll] → [44dll[necko-active]
Reporter | ||
Updated•9 years ago
|
Whiteboard: [44dll[necko-active] → [44dll][necko-active]
Comment 6•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Reporter | ||
Comment 7•9 years ago
|
||
Can you please nominate this fix for uplift?
Flags: needinfo?(daniel)
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8717357 [details] [diff] [review]
0001-bug-1246850-check-the-NotifyIpInterfaceChange-return.patch
Approval Request Comment
[Feature/regressing bug #]: 1246850
[User impact if declined]: This is suspected to be the source of a reported crash: https://crash-stats.mozilla.com/report/index/889b5884-fdbe-43c2-800d-2984f2160201
[Describe test coverage new/current, TreeHerder]: There's no particular test for this code branch.
[Risks and why]: If this code path is triggered, it rather points to an error condition elsewhere. This patch could then be a first whack-a-mole that makes the problem hit someplace else. The patch is tiny.
[String/UUID change made/needed]:
Flags: needinfo?(daniel)
Attachment #8717357 -
Flags: approval-mozilla-release?
Attachment #8717357 -
Flags: approval-mozilla-beta?
Attachment #8717357 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
status-firefox45:
--- → affected
status-firefox46:
--- → affected
Comment 9•9 years ago
|
||
Comment on attachment 8717357 [details] [diff] [review]
0001-bug-1246850-check-the-NotifyIpInterfaceChange-return.patch
Fix a crash, taking it.
Should be in 45 beta 5.
Attachment #8717357 -
Flags: approval-mozilla-beta?
Attachment #8717357 -
Flags: approval-mozilla-beta+
Attachment #8717357 -
Flags: approval-mozilla-aurora?
Attachment #8717357 -
Flags: approval-mozilla-aurora+
Comment 10•9 years ago
|
||
bugherder uplift |
Comment 11•9 years ago
|
||
bugherder uplift |
Comment 12•9 years ago
|
||
Comment on attachment 8717357 [details] [diff] [review]
0001-bug-1246850-check-the-NotifyIpInterfaceChange-return.patch
No longer relevant
Attachment #8717357 -
Flags: approval-mozilla-release? → approval-mozilla-release-
You need to log in
before you can comment on or make changes to this bug.
Description
•