Closed
Bug 1246892
Opened 9 years ago
Closed 9 years ago
[Static Analysis][Big parameter passed by value] In function ToTimingFunction
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1352020)
Attachments
(1 file)
The Static Analysis tool Coverity added that parameter aCTF is passed by value, since it's size is around 144 bytes, depending on platform alignment, we should consider passing it as a const Maybe<ComputedTimingFunction>& aCTF
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/34151/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34151/
Attachment #8717364 -
Flags: review?(roc)
Comment on attachment 8717364 [details] MozReview Request: Bug 1246892 - pass aCTF as a reference instead of value. r?roc https://reviewboard.mozilla.org/r/34151/#review30887
Attachment #8717364 -
Flags: review?(roc) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7add4193c166
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•