Closed
Bug 1247436
Opened 9 years ago
Closed 9 years ago
resurrecting a service worker registration fails to persist registration to disk
Categories
(Core :: DOM: Service Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We used to call StoreRegistration() immediately at the start of a register job. I removed this, though, because storing a registration for a service worker that may fail to install did not make sense.
Doing this, though, introduced another bug. If we resurrect an existing registration by clearing its uninstalling flag, then we can now end up with a live registration that is not persisted to disk. We should call StoreRegistration() iff we flip mPendingUninstall from true to false in the register job.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8718104 -
Flags: review?(amarchesini)
Updated•9 years ago
|
Attachment #8718104 -
Flags: review?(amarchesini) → review+
Comment 3•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•