Closed Bug 1247602 Opened 9 years ago Closed 8 years ago

Sqlite.jsm blobs support

Categories

(Toolkit :: Storage, defect, P3)

Product:
Toolkit
Component:
Storage
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: mirraz1, Assigned: mirraz1)

References

Details

Attachments

(1 file, 3 obsolete files)

Bug 1247602 - Allow to bind blobs in Sqlite.jsm.
(deleted), text/x-review-board-request
mak
: review+
Details
Attached patch blobs_support.patch (obsolete) (deleted) — — Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150305021524

Steps to reproduce:

In Sqlite.jsm there isn't any way to pass into execute function binary data for blob parameter. Proposing patch that adds blobs support.
Component: General → Storage
Attachment #8718329 - Flags: review?(mak77)
Comment on attachment 8718329 [details] [diff] [review]
blobs_support.patch

Review of attachment 8718329 [details] [diff] [review]:
-----------------------------------------------------------------

We can evaluate this addition, but please attach a proper patch format (https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F) and add a test to http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/tests/xpcshell/test_sqlite.js for the addition.
Attachment #8718329 - Flags: review?(mak77)
Assignee: nobody → mirraz1
Status: UNCONFIRMED → NEW
Ever confirmed: true
Attached patch binary_blobs_support.patch (obsolete) (deleted) — — Splinter Review 

  

  



        Attachment #8718329 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        test_datatypes.patch (obsolete) (deleted)
        — 
          — Splinter Review
      

    


  

  

  


Priority: -- → P3

        Attachment #8721451 -
        Flags: review?(mak77)

        Attachment #8721452 -
        Flags: review?(mak77)
Blocks: 887876

    
    

    
      
  


  

    
    

    
  
Comment on attachment 8829105 [details]
Bug 1247602 - Allow to bind blobs in Sqlite.jsm.

https://reviewboard.mozilla.org/r/106302/#review107276

Review in patch form.

  

  



        Attachment #8829105 -
        Flags: review?(mak77) → review+

        Attachment #8721451 -
        Attachment is obsolete: true

        Attachment #8721451 -
        Flags: review?(mak77)

        Attachment #8721452 -
        Attachment is obsolete: true

        Attachment #8721452 -
        Flags: review?(mak77)

    
    

    
  
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/160914d65dac
Allow to bind blobs in Sqlite.jsm. r=mak

  

  



    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/160914d65dac

  

  


Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox53:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1336944

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: