Closed
Bug 1247743
Opened 9 years ago
Closed 9 years ago
Expose non-pinning JS_Atomize[UC]String JSAPI functions
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8718533 -
Flags: review?(terrence)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8718533 [details] [diff] [review]
Expose non-pinning JS_Atomize[UC]String JSAPI functions
Review of attachment 8718533 [details] [diff] [review]:
-----------------------------------------------------------------
Looks reasonable to me.
::: js/src/jsapi.h
@@ +4338,5 @@
> extern JS_PUBLIC_API(JSString*)
> JS_AtomizeAndPinJSString(JSContext* cx, JS::HandleString str);
>
> extern JS_PUBLIC_API(JSString*)
> + JS_AtomizeStringN(JSContext* cx, const char* s, size_t length);
What's up with this starting whitespace? Please start the function name at the start of the line here and below.
Attachment #8718533 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8718533 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•