Closed
Bug 1247764
Opened 9 years ago
Closed 9 years ago
WebGL conformance 1.0.2 failure in context/context-attributes-alpha-depth-stencil-antialias.html
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
This fails on OSX+Intel, at least on my MBP force-restricted to Intel.
|
Assignee | |
Comment 1•9 years ago
|
||
At some point it'd be nice to clean up this heavily-inlined function into something lighter-weight.
Attachment #8718568 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8718569 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•9 years ago
|
|
||
Updated•9 years ago
|
Attachment #8718569 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8718568 [details] [diff] [review]
0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
Review of attachment 8718568 [details] [diff] [review]:
-----------------------------------------------------------------
Will this be visible to web content?
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8718568 [details] [diff] [review]
> 0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
>
> Review of attachment 8718568 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Will this be visible to web content?
No, it only swaps out the state for the draw call.
The test shows how the bug is currently visible to web content. After the fix, content will have no way to know we're doing this.
Was your concern about invisible overhead?
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8718568 [details] [diff] [review]
0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
Review of attachment 8718568 [details] [diff] [review]:
-----------------------------------------------------------------
Does this need a "Don't work around driver bugs part?"
Attachment #8718568 -
Flags: review?(jmuizelaar) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Comment on attachment 8718568 [details] [diff] [review]
> 0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
>
> Review of attachment 8718568 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Does this need a "Don't work around driver bugs part?"
What do you mean?
Flags: needinfo?(jmuizelaar)
|
||
Comment 9•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
|
Assignee | |
Comment 10•9 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)
> if (WorkAroundDriverBugs())
Yeah, I can add this.
Flags: needinfo?(jgilbert)
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(jgilbert)
You need to log in
before you can comment on or make changes to this bug.
Description
•