Closed
Bug 1247774
Opened 9 years ago
Closed 9 years ago
Port FxA L10n refactor to tv's smart-system
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zbraniecki, Assigned: zbraniecki)
References
Details
Attachments
(1 file)
In order to migrate smart-system to l20n we need to port FxA refactor from bug 1224065.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8718577 [details]
[gaia] zbraniecki:1247774-refactor-tv-fxa-to-modern-l10n > mozilla-b2g:master
This basically ports FxA changes from the System's l10n refactor to smart-system FxA.
Attachment #8718577 -
Flags: review?(rexboy)
|
||
Comment 3•9 years ago
|
||
If I understand it correctly, after this patch the only difference between TV's fxa and Phone's fxa will be that 1 is already using l20n and the other one still l10n? Am I correct?
Flags: needinfo?(gandalf)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Nope. The codebases of those modules diverged. I only ported the l10n refactor so that I can move TV system to l20n.
Flags: needinfo?(gandalf)
|
|
Assignee | |
Comment 5•9 years ago
|
||
:rexboy, can you review this for me pls? :)
Flags: needinfo?(rexboy)
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8718577 [details]
[gaia] zbraniecki:1247774-refactor-tv-fxa-to-modern-l10n > mozilla-b2g:master
Looks good to me but Yifan is the one who's using this patch so I think it's better to let him take a look. Yifan could you also review it?
Flags: needinfo?(rexboy)
Attachment #8718577 -
Flags: review?(yliao)
Attachment #8718577 -
Flags: review?(rexboy)
Attachment #8718577 -
Flags: review+
|
||
Comment 8•9 years ago
|
||
Comment on attachment 8718577 [details]
[gaia] zbraniecki:1247774-refactor-tv-fxa-to-modern-l10n > mozilla-b2g:master
Thank you keeping the TV Fxa code up to date! Sorry for the delay.
Flags: needinfo?(yliao)
Attachment #8718577 -
Flags: review?(yliao) → review+
|
|
Assignee | |
Comment 9•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•