Closed Bug 1248609 Opened 9 years ago Closed 9 years ago

Reload addon break the debugger panel

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: ochameau, Unassigned)

References

Details

Attachments

(1 file)

When reloading, we get the following errors and no source are displayed: TypeError: 'get window' called on an object that does not implement interface Window. react-dev.js:19569:0 ReferenceError: Task is not defined event-listeners.js:52:0 TypeError: DebuggerView is undefined workers-view.js:52:24 TypeError: DebuggerController is undefined variable-bubble-view.js:18:3 TypeError: DebuggerController is undefined watch-expressions-view.js:18:3 TypeError: DebuggerController is undefined global-search-view.js:18:3 TypeError: DebuggerController is undefined toolbar-view.js:19:3 TypeError: DebuggerView is undefined options-view.js:215:24 TypeError: DebuggerController is undefined stack-frames-view.js:18:3 TypeError: DebuggerView is undefined stack-frames-classic-view.js:140:39 TypeError: DebuggerController is undefined filter-view.js:19:3 TypeError: this._view is undefined
Attached patch patch v1 (deleted) — Splinter Review
Do not ask me why... I'm wondering if it is related to bug 1202902. I think it is related to xul being used in debugger and not other panels using BrowserLoader. I'm working around something really really unexpected. From debugger-controller.js, we call: String(this) ==> [object ChromeWindow] BrowserLoader(..., this); But, for some reason, and only after the addon is installed, within browser-loader.js: function BrowserLoader(_, window) { String(window) ==> [object Sandbox] Here, window stringifies to a Sandbox, but it still looks like a window object, it has all the expected properties. But then, we latter fail as it's not really a window object anymore. On the addon side, I narrowed it down to the chrome.manifest: content devtools client/ I tried disabling xul cache, but it didn't fixed that. Unfortunately, bug 1202902 isn't easily revertable anymore.
Attachment #8724068 - Flags: review?(jryans)
Comment on attachment 8724068 [details] [diff] [review] patch v1 Review of attachment 8724068 [details] [diff] [review]: ----------------------------------------------------------------- Whattttt...? I don't think I want to know. :P
Attachment #8724068 - Flags: review?(jryans) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: