Open Bug 124873 Opened 23 years ago Updated 2 years ago

[FIX]Linux File Picker has an extra "/" at start of file path

Categories

(Firefox :: File Handling, defect, P3)

x86
Linux
defect

Tracking

()

People

(Reporter: mikeypotter, Unassigned)

References

Details

Attachments

(2 files)

In my file picker, paths to files have an extra "/" at the start of them. For eg. they show up as "//home/mikep" instead of "/home/mikep". Sorry if this isn't in the right component, I don't know where it should go.
Reporter: Please always specify which "Build ID" you're using, as found in the title bar of the main Mozilla window.
I'm seeing this with tip from this morning and every build as far back as I've been working onfilepicker (a month? more?). I'm almost certain this is an nsLocalFileUnix problem. I'll take this and investigate....
Assignee: law → bzbarsky
Attached patch Patch (deleted) — Splinter Review
This should do it...
Pete, would you review?
Keywords: patch, review
Priority: -- → P2
Summary: Linux File Picker has an extra "/" at start of file path → [FIX]Linux File Picker has an extra "/" at start of file path
Target Milestone: --- → mozilla0.9.9
Comment on attachment 68982 [details] [diff] [review] Patch Looks ok, but I wonder why we don't strip trailing slashes from fragment too. /be
Attachment #68982 - Flags: superreview+
Good question. Pete? Patch checked in, but leaving bug open for now for the trailing slash issue.
Agree, the trailing slash issue is rather annoying. I can do it, if you want to do it, that's cool too . . . --pete
*** Bug 84760 has been marked as a duplicate of this bug. ***
Attached patch kill extra slashes (deleted) — Splinter Review
how's this?
From my manual page of strlen: size_t strlen(const char *s); --> it returns size_t, not ssize_t.
ssize_t is the signed version, so size_t can just be cast over to it for not too big values of size_t. I just copied that part of the code from InitWithPath, but now that I look at it there seems to be no reason to use ssize_t here _or_ there. Or in Contains() for that matter....
> for not too big values Yes, that's it. If there's no reason to use the limited datatype, why use it? Maybe use size_t in all mentioned functions.
no more time to work on this...
Assignee: bzbarsky → petejc
I am no longer seeing this, is anybody else?
Christian, see comment #7, this has been checked in.
QA Contact: sairuh → petersen
Target Milestone: mozilla0.9.9 → ---
QA Contact: chrispetersen → file-handling
Product: Core → Firefox
Version: Trunk → unspecified
Moving to p3 because no activity for at least 1 year(s). See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Moving to p3 because no activity for at least 1 year(s). See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: pete → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: