Closed
Bug 1248874
Opened 9 years ago
Closed 9 years ago
Replace Scoped.h templates used only by PSM in ScopedNSSTypes.h with UniquePtr equivalents
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
Scoped.h is deprecated, and we should start moving to UniquePtr.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/35463/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35463/
Attachment #8720783 -
Flags: review?(dkeeler)
Attachment #8720783 -
Flags: review?(dkeeler) → review+
Comment on attachment 8720783 [details]
MozReview Request: Bug 1248874 - Replace Scoped.h templates used only by PSM in ScopedNSSTypes.h with UniquePtr equivalents.
https://reviewboard.mozilla.org/r/35463/#review32309
Good stuff. Ship it!
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thanks for the review!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd22c93b12c9
(All the tier 2 failures look unrelated.)
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•