Closed
Bug 1249049
Opened 9 years ago
Closed 9 years ago
Debugging worker throws gDevTools is undefined at devtools/content/debugger/debugger-controller.js:512:7
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
Most likely introduced by bug 1245462. gDevTools was magically inserted into all scopes via a Cu.import(gDevTools.jsm). Without a second argument, Cu.import exports symbols to the global scope, which happens to be merged with Loader.jsm.
We simply need to explicitely load this symbol.
|
Assignee | |
Comment 1•9 years ago
|
||
While I'm at hit, fixing the spaces of a similar import in perf panel.
Attachment #8720370 -
Flags: review?(ejpbruel)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Sorry for the spam. This patch should apply cleanly on fx-team.
Attachment #8720371 -
Flags: review?(ejpbruel)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8720370 -
Attachment is obsolete: true
Attachment #8720370 -
Flags: review?(ejpbruel)
|
||
Updated•9 years ago
|
Attachment #8720371 -
Flags: review?(ejpbruel) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a3458328b296fd1361c817b8c9e1d1e5bfdd64bb
Bug 1249049 - Fix gDevTools is undefined exception when debugging workers. r=ejpbruel
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•