Our work in bug 1097398 has overlapping text highlights when selecting multiple rows of text. In the same test sites, Chrome doesn't have this and by comparison we look and feel quite unfinished. :TYLin suggested I check in here to see if this could be fixed. Thanks! https://bugzilla.mozilla.org/show_bug.cgi?id=1097398#c90

Why are the lines overlapping in the first place? Is that due to font-inflation in Fennec?

I have no idea why this is, but :TYLin mentioned this might need more investigation. From a UX point of view, I just want to know if we can fix this issue :)

I wonder if you're actually referring to the element highlight Fennec will produce on long-press of a link that produces a contextmenu (vs a TextSelection) ... [0] ? [0] https://www.dropbox.com/s/lqtyuxmla9t5ws7/bug_1249327_overlap.mp4?dl=0

Ah, here's more likely: https://www.dropbox.com/s/6is6v99s1eb3b3b/bug_1249327_overlap.png?dl=0

I believe comment #4 is what Anthony concerns. Selection highlight on desktop also have this issue. However the highlight looks like without any opacity so it looks OK.

The overlap there appears to be caused by the author setting 'line-height'. Does anyone have examples of overlap with a default 'line-height'?

Thinking about this some more, Chrome might have the same issue but it might be our transparency that's actually causing this to "show" more. I.e. where the orange gets darker cause its overlapping transparency. :TYLin, I may have misunderstood how this works in the code. Perhaps we don't need any transparency in the text highlight? Would the text still show through though? If you have some time, could I see a screenshot of highlight opacity at 1, instead of 0.6 ? that will help me decide what we should do here. Thanks!

Here is the screenshot with text selection highlight using fennec orange #FF9500 and alpha 1. Too dark, right?

(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #8) > Created attachment 8721616 [details] > fennec_orange_#FF9500_alpha_1.png > > Here is the screenshot with text selection highlight using fennec orange > #FF9500 and alpha 1. Too dark, right? Yeah it does seem a bit dark. I think the 0.6 opacity still creates the color we want. My original theory was that the having no transparency (i.e. opacity = 1) would resolve the overlapping issue, but the color is too vivid without it. Let me think about this some more. Thanks for your help :TYLin! :) Again, I don't think this blocks us shipping these carets ATM.