Closed
Bug 1249595
Opened 9 years ago
Closed 9 years ago
Enable 11 more ESLint rules for PSM
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: Cykesiopka, Assigned: Cykesiopka)
References
Details
Attachments
(1 file)
Misc rules that don't require too many changes to turn on, and seem worth the effort enough.
|
Assignee | |
Comment 1•9 years ago
|
||
10 -> 11 rules because I found another rule that we already pass, and seems worthwhile to have on.
Summary: Enable 10 more ESLint rules for PSM → Enable 11 more ESLint rules for PSM
|
|
Assignee | |
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36749/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36749/
Attachment #8723829 -
Flags: review?(dkeeler)
Comment on attachment 8723829 [details]
MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler
https://reviewboard.mozilla.org/r/36749/#review33477
LGTM.
::: security/manager/ssl/tests/unit/head_psm.js:49
(Diff revision 1)
> const SEC_ERROR_CERT_NOT_IN_NAME_SPACE = SEC_ERROR_BASE + 112; // -8080
Why get rid of some of these comments but not others?
Attachment #8723829 -
Flags: review?(dkeeler) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/36749/#review33477
Thanks for the review!
> Why get rid of some of these comments but not others?
It was a "while I'm here" thing, but I guess it's better to be consistent. I removed the other comments as well.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8723829 [details]
MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/36749/diff/1-2/
Attachment #8723829 -
Attachment description: MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. → MozReview Request: Bug 1249595 - Enable 11 more ESLint rules for PSM. r=keeler
|
|
Assignee | |
Comment 6•9 years ago
|
||
Keywords: checkin-needed
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•