Dão Gottwald [:dao] Assignee
	Description • 8 years ago

Running our UI migration steps with new profiles is a waste and potentially dangerous, as old steps may rot and get virtually no testing in current profiles. Unfortunately, there was no good way around this. Now that _migrateUI has been around for ages (Firefox 2 I think), we can assume that when browser.migration.version is not set, we're dealing with a new profile.

	:Gijs (he/him)
	Comment 1 • 8 years ago

Comment on attachment 8721296 [details] [diff] [review]
patch

Review of attachment 8721296 [details] [diff] [review]:
-----------------------------------------------------------------

If we're taking the broom through this (hm, maybe that's a dutch expression), can we remove:

https://dxr.mozilla.org/mozilla-central/rev/d5daf10d3b74b04e8fa63c4e5429de8a0adf79f8/browser/components/nsBrowserGlue.js#1823-1832 -- bookmarks-menu-button-container isn't a thing anymore
https://dxr.mozilla.org/mozilla-central/rev/d5daf10d3b74b04e8fa63c4e5429de8a0adf79f8/browser/components/nsBrowserGlue.js#1834-1846 -- home-button is at the end, not next to the bookmarks button

I think this:

https://dxr.mozilla.org/mozilla-central/rev/d5daf10d3b74b04e8fa63c4e5429de8a0adf79f8/browser/components/nsBrowserGlue.js#1848-1871

is redundant now that we otherwise expand the bookmarks toolbar when there are bookmarks in it?

	Marco Bonardo [:mak]
	Comment 2 • 8 years ago

(In reply to :Gijs Kruitbosch from comment #1)
> is redundant now that we otherwise expand the bookmarks toolbar when there
> are bookmarks in it?

the patch was backed out, we do not.

	Pulsebot
	Comment 3 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/ca83a163091a

	Pulsebot
	Comment 4 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/eff6731606da

	Guilherme Lima
	Comment 5 • 8 years ago

philor, it seems the patches from https://hg.mozilla.org/mozilla-central/rev/889096db9c1b didn't get marked as fixed.

	Phil Ringnalda (:philor)
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/ca83a163091a
https://hg.mozilla.org/mozilla-central/rev/eff6731606da