Closed
Bug 1250046
Opened 9 years ago
Closed 9 years ago
Remove out-of-date Shumway version
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: cpeterson, Assigned: yury)
References
Details
Attachments
(3 files, 1 obsolete file)
(deleted),
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
Details | Diff | Splinter Review |
The version of Shumway in mozilla-central is out-of-date. We should remove the in-tree snapshot. People interested in testing Shumway can install the latest add-on build from GitHub:
https://github.com/mozilla/shumway/
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ydelendik
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Mostly based on bug 904346
Attachment #8722793 -
Flags: review?(till)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8722794 -
Flags: review?(jmathies)
Assignee | ||
Comment 3•9 years ago
|
||
Removes all SHUMWAY_ entries from historgrams.json and also fixed some docs.
(P.S. https://treeherder.mozilla.org/#/jobs?repo=try&revision=a02aae369da7)
Attachment #8722795 -
Flags: review?(gfritzsche)
Comment 4•9 years ago
|
||
Comment on attachment 8722793 [details] [diff] [review]
1. Remove Shumway core files.
Review of attachment 8722793 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, with a few tears shed :(
Attachment #8722793 -
Flags: review?(till) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8722795 [details] [diff] [review]
3. Remove Shumway references from telemetry.
Review of attachment 8722795 [details] [diff] [review]:
-----------------------------------------------------------------
::: toolkit/components/telemetry/bucket-whitelist.json
@@ -44,5 @@
> "UPDATE_STATUS_ERROR_CODE_PARTIAL_STAGE",
> "UPDATE_STATUS_ERROR_CODE_UNKNOWN_STAGE",
> "SECURITY_UI",
> "CRASH_STORE_COMPRESSED_BYTES",
> - "SHUMWAY_FEATURE_USED",
Note that you might have landing-conflicts with bug 1219768, which would just mean removing some more Shumway whitelisting here.
Attachment #8722795 -
Flags: review?(gfritzsche) → review+
Updated•9 years ago
|
Attachment #8722794 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #5)
> Comment on attachment 8722795 [details] [diff] [review]
> 3. Remove Shumway references from telemetry.
>
> Review of attachment 8722795 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: toolkit/components/telemetry/bucket-whitelist.json
> @@ -44,5 @@
> > "UPDATE_STATUS_ERROR_CODE_PARTIAL_STAGE",
> > "UPDATE_STATUS_ERROR_CODE_UNKNOWN_STAGE",
> > "SECURITY_UI",
> > "CRASH_STORE_COMPRESSED_BYTES",
> > - "SHUMWAY_FEATURE_USED",
>
> Note that you might have landing-conflicts with bug 1219768, which would
> just mean removing some more Shumway whitelisting here.
Removed more SHUMWAY_ entries from toolkit/components/telemetry/histogram-whitelists.json after bug 1219768 was landed.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a94cc3c2d7c4
Attachment #8722795 -
Attachment is obsolete: true
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/db53d609ea3d
https://hg.mozilla.org/integration/fx-team/rev/cfb5ae2be5f1
https://hg.mozilla.org/integration/fx-team/rev/b0f74770edc6
Keywords: checkin-needed
Comment 8•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/db53d609ea3d
https://hg.mozilla.org/mozilla-central/rev/cfb5ae2be5f1
https://hg.mozilla.org/mozilla-central/rev/b0f74770edc6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment 9•9 years ago
|
||
by removing this we are causing TART timeouts on winxp e10s now:
https://treeherder.mozilla.org/#/jobs?repo=fx-team&filter-searchStr=talos%20svg%20xp%20e10s&tochange=952e06e0b849&fromchange=5e6d66db9b05
previously we have had a constant issue with tart on linux64, now this removal has kept linux64 as problematic and added winxp to the list.
:mconley, as one of the owners of TART, do you have any thoughts why removing Shumway might be causing TART crashes?
Flags: needinfo?(mconley)
Comment 10•9 years ago
|
||
(In reply to Joel Maher (:jmaher) from comment #9)
> by removing this we are causing TART timeouts on winxp e10s now:
> https://treeherder.mozilla.org/#/jobs?repo=fx-team&filter-
> searchStr=talos%20svg%20xp%20e10s&tochange=952e06e0b849&fromchange=5e6d66db9b
> 05
>
> previously we have had a constant issue with tart on linux64, now this
> removal has kept linux64 as problematic and added winxp to the list.
>
> :mconley, as one of the owners of TART, do you have any thoughts why
> removing Shumway might be causing TART crashes?
I can only speculate, but I'm guessing there's some time sensitivity to TART that's not well understood. Removing such a large swath of code probably changed the amount of time it takes to start up a window or a tab, and that's affecting the test.
Flags: needinfo?(mconley)
You need to log in
before you can comment on or make changes to this bug.
Description
•