Closed Bug 1250355 Opened 9 years ago Closed 4 years ago

Investigate the consistency of ScreenshotObserver

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mcomella, Unassigned)

References

Details

Attachments

(1 file)

I added a log statement to onScreenshotTaken in BrowserApp and: * On my N9, the method is not called * On my Galaxy S4, the method is called twice (I suspect Samsung might create a copy of the screenshot to provide some other user feature (e.g. editing the image)) Finkle, which devices did you test this on?
Flags: needinfo?(mark.finkle)
Attached file GS4 logcat output (deleted) —
The data associated with the two screenshot observer calls on the GS4 look identical.
The only related line I see on my N9 is: 02-22 16:31:36.615 I/ActivityManager( 565): Start proc 19228:com.android.systemui:screenshot/u0a20 for service com.android.systemui/.screenshot.TakeScreenshotService It doesn't look like onMediaChange gets called at all.
Maybe this is an internal/external storage issue? I tried updating the content uri to: MediaStore.Images.Media.INTERNAL_CONTENT_URI (from external) with no success, however.
(In reply to Michael Comella (:mcomella) from comment #0) > I added a log statement to onScreenshotTaken in BrowserApp and: > * On my N9, the method is not called > * On my Galaxy S4, the method is called twice (I suspect Samsung might > create a copy of the screenshot to provide some other user feature (e.g. > editing the image)) > > Finkle, which devices did you test this on? Nexus 4 and 5 devices. (In reply to Michael Comella (:mcomella) from comment #3) > Maybe this is an internal/external storage issue? I tried updating the > content uri to: > MediaStore.Images.Media.INTERNAL_CONTENT_URI > > (from external) with no success, however. It could certainly be related to that. I have seen code that tries to look in both places. (In reply to Michael Comella (:mcomella) from comment #1) > Created attachment 8722250 [details] > GS4 logcat output > > The data associated with the two screenshot observer calls on the GS4 look > identical. I have also seen code that caches the last screenshot filename, in cases where we get multiple calls.
Flags: needinfo?(mark.finkle)
Keep in mind, this is a hack. There appears to be no approved method for monitoring screenshots. Find the edge cases, and try to turn chaos into sanity. Expect a little chaos to seep through.
We know a significant number of devices are sending screenshot telemetry. Sure, we might be double counting due to things like comment 1, but we can clean that up.
There are problems on my memopad hd 7. Screenshots are recogniced and shown in the list, so that is ok. But there are also more and more entrys to webpages where i did not take screenshots. Those entrys lead all to the same, older screenshot. Cant say when it happens, but one time it happend when a download was finished.
Blocks: saved-screenshots
No longer blocks: 1243558
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: